antebudimir/feishin
1
0
Fork 0
mirror of https://github.com/antebudimir/feishin.git synced 2026-01-01 18:33:33 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions 1

handle undefined options in GenericCell (#998)

Browse source
This commit is contained in:
Jeff 2025-07-06 03:33:11 -07:00 • committed by GitHub
parent cd2d531c54
commit b7a0b7f997
No known key found for this signature in database
GPG key ID: B5690EEEBB952194
2 changed files with 3 additions and 5 deletions
Download patch file Download diff file Expand all files Collapse all files

6
src/renderer/components/virtual-table/cells/generic-cell.tsx
View file

@ -16,10 +16,8 @@ type Options = {
primary?: boolean; primary?: boolean;
}; };
export const GenericCell = ( export const GenericCell = ({ value, valueFormatted }: ICellRendererParams, options?: Options) => {
{ value, valueFormatted }: ICellRendererParams, const { isLink, position, primary } = options || {};
{ isLink, position, primary }: Options,
) => {
const displayedValue = valueFormatted || value; const displayedValue = valueFormatted || value;
if (value === undefined) { if (value === undefined) {

2
src/renderer/components/virtual-table/index.tsx
View file

@ -236,7 +236,7 @@ const tableColumns: { [key: string]: ColDef } = {
width: 130, width: 130,
}, },
path: { path: {
cellRenderer: GenericCell, cellRenderer: (params: ICellRendererParams) => GenericCell(params, { position: 'left' }),
colId: TableColumn.PATH, colId: TableColumn.PATH,
headerName: i18n.t('table.column.path'), headerName: i18n.t('table.column.path'),
valueGetter: (params: ValueGetterParams) => (params.data ? params.data.path : undefined), valueGetter: (params: ValueGetterParams) => (params.data ? params.data.path : undefined),