From b7a0b7f997086a2811ab09fc747455b03813fe44 Mon Sep 17 00:00:00 2001 From: Jeff <42182408+jeffvli@users.noreply.github.com> Date: Sun, 6 Jul 2025 03:33:11 -0700 Subject: [PATCH] handle undefined options in GenericCell (#998) --- .../components/virtual-table/cells/generic-cell.tsx | 6 ++---- src/renderer/components/virtual-table/index.tsx | 2 +- 2 files changed, 3 insertions(+), 5 deletions(-) diff --git a/src/renderer/components/virtual-table/cells/generic-cell.tsx b/src/renderer/components/virtual-table/cells/generic-cell.tsx index 413c4575..0cb3c1c7 100644 --- a/src/renderer/components/virtual-table/cells/generic-cell.tsx +++ b/src/renderer/components/virtual-table/cells/generic-cell.tsx @@ -16,10 +16,8 @@ type Options = { primary?: boolean; }; -export const GenericCell = ( - { value, valueFormatted }: ICellRendererParams, - { isLink, position, primary }: Options, -) => { +export const GenericCell = ({ value, valueFormatted }: ICellRendererParams, options?: Options) => { + const { isLink, position, primary } = options || {}; const displayedValue = valueFormatted || value; if (value === undefined) { diff --git a/src/renderer/components/virtual-table/index.tsx b/src/renderer/components/virtual-table/index.tsx index e650db89..894bba7d 100644 --- a/src/renderer/components/virtual-table/index.tsx +++ b/src/renderer/components/virtual-table/index.tsx @@ -236,7 +236,7 @@ const tableColumns: { [key: string]: ColDef } = { width: 130, }, path: { - cellRenderer: GenericCell, + cellRenderer: (params: ICellRendererParams) => GenericCell(params, { position: 'left' }), colId: TableColumn.PATH, headerName: i18n.t('table.column.path'), valueGetter: (params: ValueGetterParams) => (params.data ? params.data.path : undefined),