Fix a big bunch of lint warning

This commit is contained in:
CappielloAntonio 2021-08-14 17:52:46 +02:00
parent 99c956c122
commit e8a65c5810
29 changed files with 69 additions and 82 deletions

View file

@ -9,7 +9,7 @@ import android.view.View;
import com.cappielloantonio.play.ui.activity.MainActivity; import com.cappielloantonio.play.ui.activity.MainActivity;
public class ConnectivityStatusBroadcastReceiver extends BroadcastReceiver { public class ConnectivityStatusBroadcastReceiver extends BroadcastReceiver {
private MainActivity activity; private final MainActivity activity;
public ConnectivityStatusBroadcastReceiver(MainActivity activity) { public ConnectivityStatusBroadcastReceiver(MainActivity activity) {
this.activity = activity; this.activity = activity;

View file

@ -47,7 +47,7 @@ public class MediaButtonIntentReceiver extends BroadcastReceiver {
private static long mLastClickTime = 0; private static long mLastClickTime = 0;
@SuppressLint("HandlerLeak") @SuppressLint("HandlerLeak")
private static Handler mHandler = new Handler() { private static final Handler mHandler = new Handler() {
@Override @Override
public void handleMessage(final Message msg) { public void handleMessage(final Message msg) {

View file

@ -14,9 +14,9 @@ public class MusicProgressViewUpdateHelper extends Handler {
private static final int UPDATE_INTERVAL_PLAYING = 1000; private static final int UPDATE_INTERVAL_PLAYING = 1000;
private static final int UPDATE_INTERVAL_PAUSED = 500; private static final int UPDATE_INTERVAL_PAUSED = 500;
private Callback callback; private final Callback callback;
private int intervalPlaying; private final int intervalPlaying;
private int intervalPaused; private final int intervalPaused;
public MusicProgressViewUpdateHelper(Callback callback) { public MusicProgressViewUpdateHelper(Callback callback) {
this.callback = callback; this.callback = callback;

View file

@ -6,10 +6,11 @@ import androidx.annotation.NonNull;
import androidx.appcompat.app.AppCompatDelegate; import androidx.appcompat.app.AppCompatDelegate;
public class ThemeHelper { public class ThemeHelper {
private static final String TAG = "ThemeHelper";
public static final String LIGHT_MODE = "light"; public static final String LIGHT_MODE = "light";
public static final String DARK_MODE = "dark"; public static final String DARK_MODE = "dark";
public static final String DEFAULT_MODE = "default"; public static final String DEFAULT_MODE = "default";
private static final String TAG = "ThemeHelper";
public static void applyTheme(@NonNull String themePref) { public static void applyTheme(@NonNull String themePref) {
switch (themePref) { switch (themePref) {

View file

@ -6,9 +6,9 @@ import android.view.View;
import androidx.recyclerview.widget.RecyclerView; import androidx.recyclerview.widget.RecyclerView;
public class GridItemDecoration extends RecyclerView.ItemDecoration { public class GridItemDecoration extends RecyclerView.ItemDecoration {
private int spanCount; private final int spanCount;
private int spacing; private final int spacing;
private boolean includeEdge; private final boolean includeEdge;
public GridItemDecoration(int spanCount, int spacing, boolean includeEdge) { public GridItemDecoration(int spanCount, int spacing, boolean includeEdge) {
this.spanCount = spanCount; this.spanCount = spanCount;

View file

@ -27,7 +27,7 @@ import retrofit2.Response;
public class AlbumRepository { public class AlbumRepository {
private static final String TAG = "AlbumRepository"; private static final String TAG = "AlbumRepository";
private Application application; private final Application application;
public AlbumRepository(Application application) { public AlbumRepository(Application application) {
this.application = application; this.application = application;

View file

@ -46,7 +46,7 @@ public class AlbumCatalogueFragment extends Fragment {
} }
@Override @Override
public View onCreateView(LayoutInflater inflater, ViewGroup container, Bundle savedInstanceState) { public View onCreateView(@NonNull LayoutInflater inflater, ViewGroup container, Bundle savedInstanceState) {
activity = (MainActivity) getActivity(); activity = (MainActivity) getActivity();
bind = FragmentAlbumCatalogueBinding.inflate(inflater, container, false); bind = FragmentAlbumCatalogueBinding.inflate(inflater, container, false);

View file

@ -5,6 +5,7 @@ import android.view.LayoutInflater;
import android.view.View; import android.view.View;
import android.view.ViewGroup; import android.view.ViewGroup;
import androidx.annotation.NonNull;
import androidx.core.view.ViewCompat; import androidx.core.view.ViewCompat;
import androidx.fragment.app.Fragment; import androidx.fragment.app.Fragment;
import androidx.lifecycle.ViewModelProvider; import androidx.lifecycle.ViewModelProvider;
@ -25,7 +26,7 @@ public class AlbumListPageFragment extends Fragment {
private AlbumHorizontalAdapter albumHorizontalAdapter; private AlbumHorizontalAdapter albumHorizontalAdapter;
@Override @Override
public View onCreateView(LayoutInflater inflater, ViewGroup container, Bundle savedInstanceState) { public View onCreateView(@NonNull LayoutInflater inflater, ViewGroup container, Bundle savedInstanceState) {
activity = (MainActivity) getActivity(); activity = (MainActivity) getActivity();
bind = FragmentAlbumListPageBinding.inflate(inflater, container, false); bind = FragmentAlbumListPageBinding.inflate(inflater, container, false);

View file

@ -52,13 +52,13 @@ public class AlbumPageFragment extends Fragment {
} }
@Override @Override
public void onCreateOptionsMenu(Menu menu, MenuInflater inflater) { public void onCreateOptionsMenu(@NonNull Menu menu, @NonNull MenuInflater inflater) {
super.onCreateOptionsMenu(menu, inflater); super.onCreateOptionsMenu(menu, inflater);
inflater.inflate(R.menu.album_page_menu, menu); inflater.inflate(R.menu.album_page_menu, menu);
} }
@Override @Override
public View onCreateView(LayoutInflater inflater, ViewGroup container, Bundle savedInstanceState) { public View onCreateView(@NonNull LayoutInflater inflater, ViewGroup container, Bundle savedInstanceState) {
activity = (MainActivity) getActivity(); activity = (MainActivity) getActivity();
bind = FragmentAlbumPageBinding.inflate(inflater, container, false); bind = FragmentAlbumPageBinding.inflate(inflater, container, false);
@ -182,7 +182,7 @@ public class AlbumPageFragment extends Fragment {
bind.songRecyclerView.setLayoutManager(new LinearLayoutManager(requireContext())); bind.songRecyclerView.setLayoutManager(new LinearLayoutManager(requireContext()));
bind.songRecyclerView.setHasFixedSize(true); bind.songRecyclerView.setHasFixedSize(true);
songHorizontalAdapter = new SongHorizontalAdapter(activity, requireContext(), getChildFragmentManager()); songHorizontalAdapter = new SongHorizontalAdapter(activity, requireContext());
bind.songRecyclerView.setAdapter(songHorizontalAdapter); bind.songRecyclerView.setAdapter(songHorizontalAdapter);
albumPageViewModel.getAlbumSongLiveList().observe(requireActivity(), songs -> { albumPageViewModel.getAlbumSongLiveList().observe(requireActivity(), songs -> {

View file

@ -46,7 +46,7 @@ public class ArtistCatalogueFragment extends Fragment {
} }
@Override @Override
public View onCreateView(LayoutInflater inflater, ViewGroup container, Bundle savedInstanceState) { public View onCreateView(@NonNull LayoutInflater inflater, ViewGroup container, Bundle savedInstanceState) {
activity = (MainActivity) getActivity(); activity = (MainActivity) getActivity();
bind = FragmentArtistCatalogueBinding.inflate(inflater, container, false); bind = FragmentArtistCatalogueBinding.inflate(inflater, container, false);

View file

@ -5,6 +5,7 @@ import android.view.LayoutInflater;
import android.view.View; import android.view.View;
import android.view.ViewGroup; import android.view.ViewGroup;
import androidx.annotation.NonNull;
import androidx.core.view.ViewCompat; import androidx.core.view.ViewCompat;
import androidx.fragment.app.Fragment; import androidx.fragment.app.Fragment;
import androidx.lifecycle.ViewModelProvider; import androidx.lifecycle.ViewModelProvider;
@ -25,7 +26,7 @@ public class ArtistListPageFragment extends Fragment {
private ArtistHorizontalAdapter artistHorizontalAdapter; private ArtistHorizontalAdapter artistHorizontalAdapter;
@Override @Override
public View onCreateView(LayoutInflater inflater, ViewGroup container, Bundle savedInstanceState) { public View onCreateView(@NonNull LayoutInflater inflater, ViewGroup container, Bundle savedInstanceState) {
activity = (MainActivity) getActivity(); activity = (MainActivity) getActivity();
bind = FragmentArtistListPageBinding.inflate(inflater, container, false); bind = FragmentArtistListPageBinding.inflate(inflater, container, false);

View file

@ -12,6 +12,7 @@ import android.view.View;
import android.view.ViewGroup; import android.view.ViewGroup;
import android.widget.Toast; import android.widget.Toast;
import androidx.annotation.NonNull;
import androidx.annotation.Nullable; import androidx.annotation.Nullable;
import androidx.core.view.ViewCompat; import androidx.core.view.ViewCompat;
import androidx.fragment.app.Fragment; import androidx.fragment.app.Fragment;
@ -50,7 +51,7 @@ public class ArtistPageFragment extends Fragment {
private ArtistSimilarAdapter artistSimilarAdapter; private ArtistSimilarAdapter artistSimilarAdapter;
@Override @Override
public View onCreateView(LayoutInflater inflater, ViewGroup container, Bundle savedInstanceState) { public View onCreateView(@NonNull LayoutInflater inflater, ViewGroup container, Bundle savedInstanceState) {
activity = (MainActivity) getActivity(); activity = (MainActivity) getActivity();
bind = FragmentArtistPageBinding.inflate(inflater, container, false); bind = FragmentArtistPageBinding.inflate(inflater, container, false);
@ -175,7 +176,7 @@ public class ArtistPageFragment extends Fragment {
private void initTopSongsView() { private void initTopSongsView() {
bind.mostStreamedSongRecyclerView.setLayoutManager(new LinearLayoutManager(requireContext())); bind.mostStreamedSongRecyclerView.setLayoutManager(new LinearLayoutManager(requireContext()));
songHorizontalAdapter = new SongHorizontalAdapter(activity, requireContext(), getChildFragmentManager()); songHorizontalAdapter = new SongHorizontalAdapter(activity, requireContext());
bind.mostStreamedSongRecyclerView.setAdapter(songHorizontalAdapter); bind.mostStreamedSongRecyclerView.setAdapter(songHorizontalAdapter);
artistPageViewModel.getArtistTopSongList(10).observe(requireActivity(), songs -> { artistPageViewModel.getArtistTopSongList(10).observe(requireActivity(), songs -> {
if (bind != null) bind.artistPageTopSongsSector.setVisibility(!songs.isEmpty() ? View.VISIBLE : View.GONE); if (bind != null) bind.artistPageTopSongsSector.setVisibility(!songs.isEmpty() ? View.VISIBLE : View.GONE);

View file

@ -31,7 +31,6 @@ import com.cappielloantonio.play.viewmodel.GenreCatalogueViewModel;
public class GenreCatalogueFragment extends Fragment { public class GenreCatalogueFragment extends Fragment {
private static final String TAG = "GenreCatalogueFragment"; private static final String TAG = "GenreCatalogueFragment";
;
private FragmentGenreCatalogueBinding bind; private FragmentGenreCatalogueBinding bind;
private MainActivity activity; private MainActivity activity;
@ -46,7 +45,7 @@ public class GenreCatalogueFragment extends Fragment {
} }
@Override @Override
public View onCreateView(LayoutInflater inflater, ViewGroup container, Bundle savedInstanceState) { public View onCreateView(@NonNull LayoutInflater inflater, ViewGroup container, Bundle savedInstanceState) {
activity = (MainActivity) getActivity(); activity = (MainActivity) getActivity();
bind = FragmentGenreCatalogueBinding.inflate(inflater, container, false); bind = FragmentGenreCatalogueBinding.inflate(inflater, container, false);

View file

@ -248,7 +248,7 @@ public class HomeFragment extends Fragment {
private void initStarredTracksView() { private void initStarredTracksView() {
bind.starredTracksRecyclerView.setHasFixedSize(true); bind.starredTracksRecyclerView.setHasFixedSize(true);
starredSongAdapter = new SongHorizontalAdapter(activity, requireContext(), getChildFragmentManager()); starredSongAdapter = new SongHorizontalAdapter(activity, requireContext());
bind.starredTracksRecyclerView.setAdapter(starredSongAdapter); bind.starredTracksRecyclerView.setAdapter(starredSongAdapter);
homeViewModel.getStarredTracks().observe(requireActivity(), songs -> { homeViewModel.getStarredTracks().observe(requireActivity(), songs -> {
if (bind != null) { if (bind != null) {

View file

@ -43,7 +43,7 @@ public class LoginFragment extends Fragment {
} }
@Override @Override
public void onCreateOptionsMenu(Menu menu, MenuInflater inflater) { public void onCreateOptionsMenu(@NonNull Menu menu, @NonNull MenuInflater inflater) {
super.onCreateOptionsMenu(menu, inflater); super.onCreateOptionsMenu(menu, inflater);
inflater.inflate(R.menu.login_page_menu, menu); inflater.inflate(R.menu.login_page_menu, menu);
} }

View file

@ -113,9 +113,7 @@ public class PlayerBottomSheetFragment extends Fragment implements MusicServiceE
playerNowPlayingSongAdapter = new PlayerNowPlayingSongAdapter(requireContext()); playerNowPlayingSongAdapter = new PlayerNowPlayingSongAdapter(requireContext());
bind.playerBodyLayout.playerSongCoverViewPager.setAdapter(playerNowPlayingSongAdapter); bind.playerBodyLayout.playerSongCoverViewPager.setAdapter(playerNowPlayingSongAdapter);
playerBottomSheetViewModel.getQueueSong().observe(requireActivity(), queue -> { playerBottomSheetViewModel.getQueueSong().observe(requireActivity(), queue -> playerNowPlayingSongAdapter.setItems(MappingUtil.mapQueue(queue)));
playerNowPlayingSongAdapter.setItems(MappingUtil.mapQueue(queue));
});
bind.playerBodyLayout.playerSongCoverViewPager.setOffscreenPageLimit(3); bind.playerBodyLayout.playerSongCoverViewPager.setOffscreenPageLimit(3);
bind.playerBodyLayout.playerSongCoverViewPager.registerOnPageChangeCallback(new ViewPager2.OnPageChangeCallback() { bind.playerBodyLayout.playerSongCoverViewPager.registerOnPageChangeCallback(new ViewPager2.OnPageChangeCallback() {
@ -151,9 +149,7 @@ public class PlayerBottomSheetFragment extends Fragment implements MusicServiceE
playerSongQueueAdapter = new PlayerSongQueueAdapter(requireContext(), this); playerSongQueueAdapter = new PlayerSongQueueAdapter(requireContext(), this);
bind.playerBodyLayout.playerQueueRecyclerView.setAdapter(playerSongQueueAdapter); bind.playerBodyLayout.playerQueueRecyclerView.setAdapter(playerSongQueueAdapter);
playerBottomSheetViewModel.getQueueSong().observe(requireActivity(), queue -> { playerBottomSheetViewModel.getQueueSong().observe(requireActivity(), queue -> playerSongQueueAdapter.setItems(MappingUtil.mapQueue(queue)));
playerSongQueueAdapter.setItems(MappingUtil.mapQueue(queue));
});
new ItemTouchHelper(new ItemTouchHelper.SimpleCallback(ItemTouchHelper.UP | ItemTouchHelper.DOWN, ItemTouchHelper.LEFT) { new ItemTouchHelper(new ItemTouchHelper.SimpleCallback(ItemTouchHelper.UP | ItemTouchHelper.DOWN, ItemTouchHelper.LEFT) {
int originalPosition = -1; int originalPosition = -1;
@ -161,7 +157,7 @@ public class PlayerBottomSheetFragment extends Fragment implements MusicServiceE
int toPosition = -1; int toPosition = -1;
@Override @Override
public boolean onMove(RecyclerView recyclerView, RecyclerView.ViewHolder viewHolder, RecyclerView.ViewHolder target) { public boolean onMove(@NonNull RecyclerView recyclerView, @NonNull RecyclerView.ViewHolder viewHolder, RecyclerView.ViewHolder target) {
if (originalPosition == -1) if (originalPosition == -1)
originalPosition = viewHolder.getBindingAdapterPosition(); originalPosition = viewHolder.getBindingAdapterPosition();
@ -203,7 +199,7 @@ public class PlayerBottomSheetFragment extends Fragment implements MusicServiceE
} }
@Override @Override
public void onSwiped(RecyclerView.ViewHolder viewHolder, int direction) { public void onSwiped(@NonNull RecyclerView.ViewHolder viewHolder, int direction) {
if (!(viewHolder.getBindingAdapterPosition() == MusicPlayerRemote.getPosition()) && !(MusicPlayerRemote.getPlayingQueue().size() <= 1)) { if (!(viewHolder.getBindingAdapterPosition() == MusicPlayerRemote.getPosition()) && !(MusicPlayerRemote.getPlayingQueue().size() <= 1)) {
MusicPlayerRemote.removeFromQueue(viewHolder.getBindingAdapterPosition()); MusicPlayerRemote.removeFromQueue(viewHolder.getBindingAdapterPosition());
playerBottomSheetViewModel.removeSong(viewHolder.getBindingAdapterPosition()); playerBottomSheetViewModel.removeSong(viewHolder.getBindingAdapterPosition());
@ -295,11 +291,7 @@ public class PlayerBottomSheetFragment extends Fragment implements MusicServiceE
} }
protected void updatePlayPauseState() { protected void updatePlayPauseState() {
if (MusicPlayerRemote.isPlaying()) { bind.playerHeaderLayout.playerHeaderButton.setChecked(!MusicPlayerRemote.isPlaying());
bind.playerHeaderLayout.playerHeaderButton.setChecked(false);
} else {
bind.playerHeaderLayout.playerHeaderButton.setChecked(true);
}
} }
private void setUpMusicControllers() { private void setUpMusicControllers() {

View file

@ -28,7 +28,6 @@ import com.cappielloantonio.play.viewmodel.PlaylistCatalogueViewModel;
public class PlaylistCatalogueFragment extends Fragment { public class PlaylistCatalogueFragment extends Fragment {
private static final String TAG = "GenreCatalogueFragment"; private static final String TAG = "GenreCatalogueFragment";
;
private FragmentPlaylistCatalogueBinding bind; private FragmentPlaylistCatalogueBinding bind;
private MainActivity activity; private MainActivity activity;
@ -45,7 +44,7 @@ public class PlaylistCatalogueFragment extends Fragment {
} }
@Override @Override
public View onCreateView(LayoutInflater inflater, ViewGroup container, Bundle savedInstanceState) { public View onCreateView(@NonNull LayoutInflater inflater, ViewGroup container, Bundle savedInstanceState) {
activity = (MainActivity) getActivity(); activity = (MainActivity) getActivity();
bind = FragmentPlaylistCatalogueBinding.inflate(inflater, container, false); bind = FragmentPlaylistCatalogueBinding.inflate(inflater, container, false);

View file

@ -46,13 +46,13 @@ public class PlaylistPageFragment extends Fragment {
} }
@Override @Override
public void onCreateOptionsMenu(Menu menu, MenuInflater inflater) { public void onCreateOptionsMenu(@NonNull Menu menu, @NonNull MenuInflater inflater) {
super.onCreateOptionsMenu(menu, inflater); super.onCreateOptionsMenu(menu, inflater);
inflater.inflate(R.menu.playlist_page_menu, menu); inflater.inflate(R.menu.playlist_page_menu, menu);
} }
@Override @Override
public View onCreateView(LayoutInflater inflater, ViewGroup container, Bundle savedInstanceState) { public View onCreateView(@NonNull LayoutInflater inflater, ViewGroup container, Bundle savedInstanceState) {
activity = (MainActivity) getActivity(); activity = (MainActivity) getActivity();
bind = FragmentPlaylistPageBinding.inflate(inflater, container, false); bind = FragmentPlaylistPageBinding.inflate(inflater, container, false);
@ -154,7 +154,7 @@ public class PlaylistPageFragment extends Fragment {
bind.songRecyclerView.setLayoutManager(new LinearLayoutManager(requireContext())); bind.songRecyclerView.setLayoutManager(new LinearLayoutManager(requireContext()));
bind.songRecyclerView.setHasFixedSize(true); bind.songRecyclerView.setHasFixedSize(true);
songHorizontalAdapter = new SongHorizontalAdapter(activity, requireContext(), getChildFragmentManager()); songHorizontalAdapter = new SongHorizontalAdapter(activity, requireContext());
bind.songRecyclerView.setAdapter(songHorizontalAdapter); bind.songRecyclerView.setAdapter(songHorizontalAdapter);
playlistPageViewModel.getPlaylistSongLiveList().observe(requireActivity(), songs -> { playlistPageViewModel.getPlaylistSongLiveList().observe(requireActivity(), songs -> {

View file

@ -73,7 +73,7 @@ public class SearchFragment extends Fragment {
bind.searchResultTracksRecyclerView.setLayoutManager(new LinearLayoutManager(requireContext())); bind.searchResultTracksRecyclerView.setLayoutManager(new LinearLayoutManager(requireContext()));
bind.searchResultTracksRecyclerView.setHasFixedSize(true); bind.searchResultTracksRecyclerView.setHasFixedSize(true);
songHorizontalAdapter = new SongHorizontalAdapter(activity, requireContext(), getChildFragmentManager()); songHorizontalAdapter = new SongHorizontalAdapter(activity, requireContext());
bind.searchResultTracksRecyclerView.setAdapter(songHorizontalAdapter); bind.searchResultTracksRecyclerView.setAdapter(songHorizontalAdapter);
// Albums // Albums
@ -107,9 +107,7 @@ public class SearchFragment extends Fragment {
bind.persistentSearchView.setOnSearchQueryChangeListener((searchView, oldQuery, newQuery) -> { bind.persistentSearchView.setOnSearchQueryChangeListener((searchView, oldQuery, newQuery) -> {
if (!newQuery.trim().equals("") && newQuery.trim().length() > 1) { if (!newQuery.trim().equals("") && newQuery.trim().length() > 1) {
searchViewModel.getSearchSuggestion(newQuery).observe(requireActivity(), suggestions -> { searchViewModel.getSearchSuggestion(newQuery).observe(requireActivity(), suggestions -> searchView.setSuggestions(SuggestionCreationUtil.asRegularSearchSuggestions(MusicUtil.getReadableStrings(suggestions)), false));
searchView.setSuggestions(SuggestionCreationUtil.asRegularSearchSuggestions(MusicUtil.getReadableStrings(suggestions)), false);
});
} else { } else {
setSuggestions(); setSuggestions();
} }

View file

@ -5,6 +5,7 @@ import android.view.LayoutInflater;
import android.view.View; import android.view.View;
import android.view.ViewGroup; import android.view.ViewGroup;
import androidx.annotation.NonNull;
import androidx.lifecycle.ViewModelProvider; import androidx.lifecycle.ViewModelProvider;
import androidx.preference.ListPreference; import androidx.preference.ListPreference;
import androidx.preference.PreferenceFragmentCompat; import androidx.preference.PreferenceFragmentCompat;
@ -23,7 +24,7 @@ public class SettingsFragment extends PreferenceFragmentCompat {
private SettingViewModel settingViewModel; private SettingViewModel settingViewModel;
@Override @Override
public View onCreateView(LayoutInflater inflater, ViewGroup container, Bundle savedInstanceState) { public View onCreateView(@NonNull LayoutInflater inflater, ViewGroup container, Bundle savedInstanceState) {
activity = (MainActivity) getActivity(); activity = (MainActivity) getActivity();
View view = super.onCreateView(inflater, container, savedInstanceState); View view = super.onCreateView(inflater, container, savedInstanceState);

View file

@ -6,6 +6,7 @@ import android.view.LayoutInflater;
import android.view.View; import android.view.View;
import android.view.ViewGroup; import android.view.ViewGroup;
import androidx.annotation.NonNull;
import androidx.core.view.ViewCompat; import androidx.core.view.ViewCompat;
import androidx.fragment.app.Fragment; import androidx.fragment.app.Fragment;
import androidx.lifecycle.ViewModelProvider; import androidx.lifecycle.ViewModelProvider;
@ -32,7 +33,7 @@ public class SongListPageFragment extends Fragment {
private SongHorizontalAdapter songHorizontalAdapter; private SongHorizontalAdapter songHorizontalAdapter;
@Override @Override
public View onCreateView(LayoutInflater inflater, ViewGroup container, Bundle savedInstanceState) { public View onCreateView(@NonNull LayoutInflater inflater, ViewGroup container, Bundle savedInstanceState) {
activity = (MainActivity) getActivity(); activity = (MainActivity) getActivity();
bind = FragmentSongListPageBinding.inflate(inflater, container, false); bind = FragmentSongListPageBinding.inflate(inflater, container, false);
@ -103,9 +104,7 @@ public class SongListPageFragment extends Fragment {
activity.getSupportActionBar().setDisplayShowHomeEnabled(true); activity.getSupportActionBar().setDisplayShowHomeEnabled(true);
} }
bind.toolbar.setNavigationOnClickListener(v -> { bind.toolbar.setNavigationOnClickListener(v -> activity.navController.navigateUp());
activity.navController.navigateUp();
});
bind.appBarLayout.addOnOffsetChangedListener((appBarLayout, verticalOffset) -> { bind.appBarLayout.addOnOffsetChangedListener((appBarLayout, verticalOffset) -> {
if ((bind.albumInfoSector.getHeight() + verticalOffset) < (2 * ViewCompat.getMinimumHeight(bind.toolbar))) { if ((bind.albumInfoSector.getHeight() + verticalOffset) < (2 * ViewCompat.getMinimumHeight(bind.toolbar))) {
@ -138,7 +137,7 @@ public class SongListPageFragment extends Fragment {
bind.songListRecyclerView.setLayoutManager(new LinearLayoutManager(requireContext())); bind.songListRecyclerView.setLayoutManager(new LinearLayoutManager(requireContext()));
bind.songListRecyclerView.setHasFixedSize(true); bind.songListRecyclerView.setHasFixedSize(true);
songHorizontalAdapter = new SongHorizontalAdapter(activity, requireContext(), getChildFragmentManager()); songHorizontalAdapter = new SongHorizontalAdapter(activity, requireContext());
bind.songListRecyclerView.setAdapter(songHorizontalAdapter); bind.songListRecyclerView.setAdapter(songHorizontalAdapter);
songListPageViewModel.getSongList().observe(requireActivity(), songs -> songHorizontalAdapter.setItems(songs)); songListPageViewModel.getSongList().observe(requireActivity(), songs -> songHorizontalAdapter.setItems(songs));
} }

View file

@ -39,8 +39,6 @@ import java.util.List;
public class AlbumBottomSheetDialog extends BottomSheetDialogFragment implements View.OnClickListener { public class AlbumBottomSheetDialog extends BottomSheetDialogFragment implements View.OnClickListener {
private static final String TAG = "AlbumBottomSheetDialog"; private static final String TAG = "AlbumBottomSheetDialog";
private MainActivity activity;
private AlbumBottomSheetViewModel albumBottomSheetViewModel; private AlbumBottomSheetViewModel albumBottomSheetViewModel;
private Album album; private Album album;
@ -60,8 +58,6 @@ public class AlbumBottomSheetDialog extends BottomSheetDialogFragment implements
} }
private void init(View view) { private void init(View view) {
activity = (MainActivity) requireActivity();
ImageView coverAlbum = view.findViewById(R.id.album_cover_image_view); ImageView coverAlbum = view.findViewById(R.id.album_cover_image_view);
CustomGlideRequest.Builder CustomGlideRequest.Builder
.from(requireContext(), albumBottomSheetViewModel.getAlbum().getPrimary(), CustomGlideRequest.ALBUM_PIC, null) .from(requireContext(), albumBottomSheetViewModel.getAlbum().getPrimary(), CustomGlideRequest.ALBUM_PIC, null)
@ -100,8 +96,8 @@ public class AlbumBottomSheetDialog extends BottomSheetDialogFragment implements
QueueRepository queueRepository = new QueueRepository(App.getInstance()); QueueRepository queueRepository = new QueueRepository(App.getInstance());
queueRepository.insertAllAndStartNew((ArrayList<Song>) media); queueRepository.insertAllAndStartNew((ArrayList<Song>) media);
activity.isBottomSheetInPeek(true); ((MainActivity) requireActivity()).isBottomSheetInPeek(true);
activity.setBottomSheetMusicInfo((Song) media.get(0)); ((MainActivity) requireActivity()).setBottomSheetMusicInfo((Song) media.get(0));
MusicPlayerRemote.openQueue((List<Song>) media, 0, true); MusicPlayerRemote.openQueue((List<Song>) media, 0, true);
} else { } else {
@ -123,7 +119,7 @@ public class AlbumBottomSheetDialog extends BottomSheetDialogFragment implements
queueRepository.insertAllAndStartNew(songs); queueRepository.insertAllAndStartNew(songs);
MusicPlayerRemote.openQueue(songs, 0, true); MusicPlayerRemote.openQueue(songs, 0, true);
activity.isBottomSheetInPeek(true); ((MainActivity) requireActivity()).isBottomSheetInPeek(true);
dismissBottomSheet(); dismissBottomSheet();
}); });
@ -133,7 +129,7 @@ public class AlbumBottomSheetDialog extends BottomSheetDialogFragment implements
playNext.setOnClickListener(v -> { playNext.setOnClickListener(v -> {
albumBottomSheetViewModel.getAlbumTracks().observe(requireActivity(), songs -> { albumBottomSheetViewModel.getAlbumTracks().observe(requireActivity(), songs -> {
MusicPlayerRemote.playNext(songs); MusicPlayerRemote.playNext(songs);
activity.isBottomSheetInPeek(true); ((MainActivity) requireActivity()).isBottomSheetInPeek(true);
dismissBottomSheet(); dismissBottomSheet();
}); });
}); });

View file

@ -36,8 +36,6 @@ import java.util.List;
public class ArtistBottomSheetDialog extends BottomSheetDialogFragment implements View.OnClickListener { public class ArtistBottomSheetDialog extends BottomSheetDialogFragment implements View.OnClickListener {
private static final String TAG = "AlbumBottomSheetDialog"; private static final String TAG = "AlbumBottomSheetDialog";
private MainActivity activity;
private ArtistBottomSheetViewModel artistBottomSheetViewModel; private ArtistBottomSheetViewModel artistBottomSheetViewModel;
private Artist artist; private Artist artist;
@ -57,8 +55,6 @@ public class ArtistBottomSheetDialog extends BottomSheetDialogFragment implement
} }
private void init(View view) { private void init(View view) {
activity = (MainActivity) requireActivity();
ImageView coverArtist = view.findViewById(R.id.artist_cover_image_view); ImageView coverArtist = view.findViewById(R.id.artist_cover_image_view);
CustomGlideRequest.Builder CustomGlideRequest.Builder
.from(requireContext(), artistBottomSheetViewModel.getArtist().getPrimary(), CustomGlideRequest.ARTIST_PIC, null) .from(requireContext(), artistBottomSheetViewModel.getArtist().getPrimary(), CustomGlideRequest.ARTIST_PIC, null)
@ -94,8 +90,8 @@ public class ArtistBottomSheetDialog extends BottomSheetDialogFragment implement
QueueRepository queueRepository = new QueueRepository(App.getInstance()); QueueRepository queueRepository = new QueueRepository(App.getInstance());
queueRepository.insertAllAndStartNew((ArrayList<Song>) media); queueRepository.insertAllAndStartNew((ArrayList<Song>) media);
activity.isBottomSheetInPeek(true); ((MainActivity) requireActivity()).isBottomSheetInPeek(true);
activity.setBottomSheetMusicInfo((Song) media.get(0)); ((MainActivity) requireActivity()).setBottomSheetMusicInfo((Song) media.get(0));
MusicPlayerRemote.openQueue((List<Song>) media, 0, true); MusicPlayerRemote.openQueue((List<Song>) media, 0, true);
} else { } else {
@ -116,7 +112,7 @@ public class ArtistBottomSheetDialog extends BottomSheetDialogFragment implement
queueRepository.insertAllAndStartNew(songs); queueRepository.insertAllAndStartNew(songs);
MusicPlayerRemote.openQueue(songs, 0, true); MusicPlayerRemote.openQueue(songs, 0, true);
activity.isBottomSheetInPeek(true); ((MainActivity) requireActivity()).isBottomSheetInPeek(true);
} else { } else {
Toast.makeText(requireContext(), "Error retrieving artist's songs", Toast.LENGTH_SHORT).show(); Toast.makeText(requireContext(), "Error retrieving artist's songs", Toast.LENGTH_SHORT).show();
} }

View file

@ -43,8 +43,6 @@ public class SongBottomSheetDialog extends BottomSheetDialogFragment implements
private SongBottomSheetViewModel songBottomSheetViewModel; private SongBottomSheetViewModel songBottomSheetViewModel;
private Song song; private Song song;
private TextView download;
@Nullable @Nullable
@Override @Override
public View onCreateView(LayoutInflater inflater, @Nullable ViewGroup container, @Nullable Bundle savedInstanceState) { public View onCreateView(LayoutInflater inflater, @Nullable ViewGroup container, @Nullable Bundle savedInstanceState) {
@ -149,7 +147,7 @@ public class SongBottomSheetDialog extends BottomSheetDialogFragment implements
dismissBottomSheet(); dismissBottomSheet();
}); });
download = view.findViewById(R.id.download_text_view); TextView download = view.findViewById(R.id.download_text_view);
download.setOnClickListener(v -> { download.setOnClickListener(v -> {
DownloadUtil.getDownloadTracker(requireContext()).toggleDownload(Arrays.asList(song)); DownloadUtil.getDownloadTracker(requireContext()).toggleDownload(Arrays.asList(song));
dismissBottomSheet(); dismissBottomSheet();

View file

@ -6,6 +6,7 @@ import android.os.Bundle;
import android.view.LayoutInflater; import android.view.LayoutInflater;
import android.view.View; import android.view.View;
import androidx.annotation.NonNull;
import androidx.fragment.app.DialogFragment; import androidx.fragment.app.DialogFragment;
import androidx.lifecycle.ViewModelProvider; import androidx.lifecycle.ViewModelProvider;
import androidx.recyclerview.widget.LinearLayoutManager; import androidx.recyclerview.widget.LinearLayoutManager;
@ -25,6 +26,7 @@ public class PlaylistChooserDialog extends DialogFragment {
private PlaylistHorizontalAdapter playlistHorizontalAdapter; private PlaylistHorizontalAdapter playlistHorizontalAdapter;
@NonNull
@Override @Override
public Dialog onCreateDialog(Bundle savedInstanceState) { public Dialog onCreateDialog(Bundle savedInstanceState) {
bind = DialogPlaylistChooserBinding.inflate(LayoutInflater.from(requireContext())); bind = DialogPlaylistChooserBinding.inflate(LayoutInflater.from(requireContext()));

View file

@ -28,16 +28,14 @@ public class PlaylistEditorDialog extends DialogFragment {
private static final String TAG = "ServerSignupDialog"; private static final String TAG = "ServerSignupDialog";
private DialogPlaylistEditorBinding bind; private DialogPlaylistEditorBinding bind;
private MainActivity activity;
private PlaylistEditorViewModel playlistEditorViewModel; private PlaylistEditorViewModel playlistEditorViewModel;
private String playlistName; private String playlistName;
private PlaylistDialogSongHorizontalAdapter playlistDialogSongHorizontalAdapter; private PlaylistDialogSongHorizontalAdapter playlistDialogSongHorizontalAdapter;
@NonNull
@Override @Override
public Dialog onCreateDialog(Bundle savedInstanceState) { public Dialog onCreateDialog(Bundle savedInstanceState) {
activity = (MainActivity) getActivity();
bind = DialogPlaylistEditorBinding.inflate(LayoutInflater.from(requireContext())); bind = DialogPlaylistEditorBinding.inflate(LayoutInflater.from(requireContext()));
playlistEditorViewModel = new ViewModelProvider(requireActivity()).get(PlaylistEditorViewModel.class); playlistEditorViewModel = new ViewModelProvider(requireActivity()).get(PlaylistEditorViewModel.class);

View file

@ -6,6 +6,7 @@ import android.content.Context;
import android.os.Bundle; import android.os.Bundle;
import android.view.LayoutInflater; import android.view.LayoutInflater;
import androidx.annotation.NonNull;
import androidx.fragment.app.DialogFragment; import androidx.fragment.app.DialogFragment;
import androidx.lifecycle.ViewModelProvider; import androidx.lifecycle.ViewModelProvider;
@ -22,6 +23,7 @@ public class RatingDialog extends DialogFragment {
private DialogRatingBinding bind; private DialogRatingBinding bind;
private RatingViewModel ratingViewModel; private RatingViewModel ratingViewModel;
@NonNull
@Override @Override
public Dialog onCreateDialog(Bundle savedInstanceState) { public Dialog onCreateDialog(Bundle savedInstanceState) {
bind = DialogRatingBinding.inflate(LayoutInflater.from(requireContext())); bind = DialogRatingBinding.inflate(LayoutInflater.from(requireContext()));

View file

@ -9,6 +9,7 @@ import android.util.Log;
import android.view.LayoutInflater; import android.view.LayoutInflater;
import android.widget.Toast; import android.widget.Toast;
import androidx.annotation.NonNull;
import androidx.fragment.app.DialogFragment; import androidx.fragment.app.DialogFragment;
import androidx.lifecycle.ViewModelProvider; import androidx.lifecycle.ViewModelProvider;
@ -41,6 +42,7 @@ public class ServerSignupDialog extends DialogFragment {
private String server; private String server;
private boolean directAccess = false; private boolean directAccess = false;
@NonNull
@Override @Override
public Dialog onCreateDialog(Bundle savedInstanceState) { public Dialog onCreateDialog(Bundle savedInstanceState) {
activity = (MainActivity) getActivity(); activity = (MainActivity) getActivity();

View file

@ -89,16 +89,17 @@ public class MusicUtil {
} }
public static int getDefaultPicPerCategory(String category) { public static int getDefaultPicPerCategory(String category) {
if (category.equals(CustomGlideRequest.SONG_PIC)) { switch (category) {
return R.drawable.default_album_art; case CustomGlideRequest.SONG_PIC:
} else if (category.equals(CustomGlideRequest.ALBUM_PIC)) { return R.drawable.default_album_art;
return R.drawable.default_album_art; case CustomGlideRequest.ALBUM_PIC:
} else if (category.equals(CustomGlideRequest.ARTIST_PIC)) { return R.drawable.default_album_art;
return R.drawable.default_album_art; case CustomGlideRequest.ARTIST_PIC:
} else if (category.equals(CustomGlideRequest.PLAYLIST_PIC)) { return R.drawable.default_album_art;
return R.drawable.default_album_art; case CustomGlideRequest.PLAYLIST_PIC:
} else { return R.drawable.default_album_art;
return R.drawable.default_album_art; default:
return R.drawable.default_album_art;
} }
} }