From 98a45b6059a28224f4725970d2c75846af609196 Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Jaime=20Garc=C3=ADa?=
<55400857+jaime-grj@users.noreply.github.com>
Date: Mon, 11 Aug 2025 22:26:30 +0200
Subject: [PATCH] fix: added transcoding codec and bitrate info to
PlayerControllerFragment, replace hardcoded strings with dynamic values
---
.../tempo/ui/fragment/PlayerControllerFragment.java | 6 +++---
app/src/main/res/values-es-rES/strings.xml | 3 +++
app/src/main/res/values/strings.xml | 3 +++
3 files changed, 9 insertions(+), 3 deletions(-)
diff --git a/app/src/main/java/com/cappielloantonio/tempo/ui/fragment/PlayerControllerFragment.java b/app/src/main/java/com/cappielloantonio/tempo/ui/fragment/PlayerControllerFragment.java
index 37cd9f10..9696f2c5 100644
--- a/app/src/main/java/com/cappielloantonio/tempo/ui/fragment/PlayerControllerFragment.java
+++ b/app/src/main/java/com/cappielloantonio/tempo/ui/fragment/PlayerControllerFragment.java
@@ -192,7 +192,7 @@ public class PlayerControllerFragment extends Fragment {
private void setMediaInfo(MediaMetadata mediaMetadata) {
if (mediaMetadata.extras != null) {
- String extension = mediaMetadata.extras.getString("suffix", "Unknown format");
+ String extension = mediaMetadata.extras.getString("suffix", getString(R.string.player_unknown_format));
String bitrate = mediaMetadata.extras.getInt("bitrate", 0) != 0 ? mediaMetadata.extras.getInt("bitrate", 0) + "kbps" : "Original";
String samplingRate = mediaMetadata.extras.getInt("samplingRate", 0) != 0 ? new DecimalFormat("0.#").format(mediaMetadata.extras.getInt("samplingRate", 0) / 1000.0) + "kHz" : "";
String bitDepth = mediaMetadata.extras.getInt("bitDepth", 0) != 0 ? mediaMetadata.extras.getInt("bitDepth", 0) + "b" : "";
@@ -218,8 +218,8 @@ public class PlayerControllerFragment extends Fragment {
boolean isTranscodingBitrate = !MusicUtil.getBitratePreference().equals("0");
if (isTranscodingExtension || isTranscodingBitrate) {
- playerMediaExtension.setText("Transcoding");
- playerMediaBitrate.setText("requested");
+ playerMediaExtension.setText(MusicUtil.getTranscodingFormatPreference() + " (" + getString(R.string.player_transcoding) + ")");
+ playerMediaBitrate.setText(!MusicUtil.getBitratePreference().equals("0") ? MusicUtil.getBitratePreference() + "kbps" : getString(R.string.player_transcoding_requested));
}
playerTrackInfo.setOnClickListener(view -> {
diff --git a/app/src/main/res/values-es-rES/strings.xml b/app/src/main/res/values-es-rES/strings.xml
index 4f7beefd..518931af 100644
--- a/app/src/main/res/values-es-rES/strings.xml
+++ b/app/src/main/res/values-es-rES/strings.xml
@@ -196,6 +196,9 @@
%1$.2fx
Limpiar la cola de reproducción
Prioridad del servidor
+ Formato desconocido
+ Transcodificando
+ solicitado
Catálogo de listas de reproducción
Explorar listas de reproducción
No hay listas de reproducción
diff --git a/app/src/main/res/values/strings.xml b/app/src/main/res/values/strings.xml
index faea756e..dd2b066e 100644
--- a/app/src/main/res/values/strings.xml
+++ b/app/src/main/res/values/strings.xml
@@ -193,6 +193,9 @@
%1$.2fx
Clean play queue
Server Priority
+ Unknown format
+ Transcoding
+ requested
Playlist Catalogue
Browse Playlists
No playlists created