From a4dc5f643deafe27934d5780df7f8c5c241b7168 Mon Sep 17 00:00:00 2001 From: CappielloAntonio Date: Mon, 19 Apr 2021 18:21:42 +0200 Subject: [PATCH] Check bind object before hiding view --- .../play/ui/fragment/HomeFragment.java | 23 ++++++++++--------- .../play/ui/fragment/LibraryFragment.java | 2 +- 2 files changed, 13 insertions(+), 12 deletions(-) diff --git a/app/src/main/java/com/cappielloantonio/play/ui/fragment/HomeFragment.java b/app/src/main/java/com/cappielloantonio/play/ui/fragment/HomeFragment.java index 49651963..1d27d8c2 100644 --- a/app/src/main/java/com/cappielloantonio/play/ui/fragment/HomeFragment.java +++ b/app/src/main/java/com/cappielloantonio/play/ui/fragment/HomeFragment.java @@ -123,8 +123,7 @@ public class HomeFragment extends Fragment { bind.mostPlayedTracksRecyclerView.setAdapter(mostPlayedMusicAdapter); homeViewModel.getMostPlayedSongList().observe(requireActivity(), songs -> { if(songs.size() < 10) reorder(); - - bind.homeMostPlayedTracksSector.setVisibility(!songs.isEmpty() ? View.VISIBLE : View.GONE); + if(bind != null) bind.homeMostPlayedTracksSector.setVisibility(!songs.isEmpty() ? View.VISIBLE : View.GONE); mostPlayedMusicAdapter.setItems(songs); }); } @@ -136,7 +135,7 @@ public class HomeFragment extends Fragment { recentlyPlayedMusicAdapter = new RecentMusicAdapter(activity, requireContext(), getChildFragmentManager()); bind.recentlyPlayedTracksRecyclerView.setAdapter(recentlyPlayedMusicAdapter); homeViewModel.getRecentlyPlayedSongList().observe(requireActivity(), songs -> { - bind.homeRecentlyPlayedTracksSector.setVisibility(!songs.isEmpty() ? View.VISIBLE : View.GONE); + if(bind != null) bind.homeRecentlyPlayedTracksSector.setVisibility(!songs.isEmpty() ? View.VISIBLE : View.GONE); recentlyPlayedMusicAdapter.setItems(songs); }); } @@ -162,7 +161,7 @@ public class HomeFragment extends Fragment { favoriteSongAdapter = new SongResultSearchAdapter(activity, requireContext(), getChildFragmentManager()); bind.favoritesTracksRecyclerView.setAdapter(favoriteSongAdapter); homeViewModel.getFavorites().observe(requireActivity(), songs -> { - bind.homeFavoriteTracksSector.setVisibility(!songs.isEmpty() ? View.VISIBLE : View.GONE); + if(bind != null) bind.homeFavoriteTracksSector.setVisibility(!songs.isEmpty() ? View.VISIBLE : View.GONE); favoriteSongAdapter.setItems(songs); }); @@ -202,12 +201,14 @@ public class HomeFragment extends Fragment { * - Discovery - Recently_added - Year - Favorite - Most_played - Last_played */ public void reorder() { - bind.homeLinearLayoutContainer.removeAllViews(); - bind.homeLinearLayoutContainer.addView(bind.homeDiscoverSector); - bind.homeLinearLayoutContainer.addView(bind.homeRecentlyAddedTracksSector); - bind.homeLinearLayoutContainer.addView(bind.homeFlashbackSector); - bind.homeLinearLayoutContainer.addView(bind.homeFavoriteTracksSector); - bind.homeLinearLayoutContainer.addView(bind.homeMostPlayedTracksSector); - bind.homeLinearLayoutContainer.addView(bind.homeRecentlyPlayedTracksSector); + if(bind != null) { + bind.homeLinearLayoutContainer.removeAllViews(); + bind.homeLinearLayoutContainer.addView(bind.homeDiscoverSector); + bind.homeLinearLayoutContainer.addView(bind.homeRecentlyAddedTracksSector); + bind.homeLinearLayoutContainer.addView(bind.homeFlashbackSector); + bind.homeLinearLayoutContainer.addView(bind.homeFavoriteTracksSector); + bind.homeLinearLayoutContainer.addView(bind.homeMostPlayedTracksSector); + bind.homeLinearLayoutContainer.addView(bind.homeRecentlyPlayedTracksSector); + } } } diff --git a/app/src/main/java/com/cappielloantonio/play/ui/fragment/LibraryFragment.java b/app/src/main/java/com/cappielloantonio/play/ui/fragment/LibraryFragment.java index 8ae01849..e3deef9b 100644 --- a/app/src/main/java/com/cappielloantonio/play/ui/fragment/LibraryFragment.java +++ b/app/src/main/java/com/cappielloantonio/play/ui/fragment/LibraryFragment.java @@ -122,7 +122,7 @@ public class LibraryFragment extends Fragment { playlistAdapter = new PlaylistAdapter(requireContext()); bind.playlistRecyclerView.setAdapter(playlistAdapter); libraryViewModel.getPlaylistList().observe(requireActivity(), playlists -> { - bind.libraryPlaylistSector.setVisibility(playlists.size() > 0 ? View.VISIBLE : View.GONE); + if(bind != null) bind.libraryPlaylistSector.setVisibility(playlists.size() > 0 ? View.VISIBLE : View.GONE); playlistAdapter.setItems(playlists); }); }