Fix a bunch of lint warning

This commit is contained in:
CappielloAntonio 2021-08-14 17:21:45 +02:00
parent a49626aa43
commit 81ba6970f5
19 changed files with 36 additions and 256 deletions

View file

@ -36,7 +36,6 @@ public class AlbumCatalogueFragment extends Fragment {
private AlbumCatalogueViewModel albumCatalogueViewModel;
private AlbumCatalogueAdapter albumAdapter;
private GridLayoutManager gridLayoutManager;
@Override
public void onCreate(@Nullable Bundle savedInstanceState) {
@ -101,7 +100,7 @@ public class AlbumCatalogueFragment extends Fragment {
@SuppressLint("ClickableViewAccessibility")
private void initAlbumCatalogueView() {
gridLayoutManager = new GridLayoutManager(requireContext(), 2);
GridLayoutManager gridLayoutManager = new GridLayoutManager(requireContext(), 2);
bind.albumCatalogueRecyclerView.setLayoutManager(gridLayoutManager);
bind.albumCatalogueRecyclerView.addItemDecoration(new GridItemDecoration(2, 20, false));

View file

@ -44,18 +44,6 @@ public class AlbumBottomSheetDialog extends BottomSheetDialogFragment implements
private AlbumBottomSheetViewModel albumBottomSheetViewModel;
private Album album;
private ImageView coverAlbum;
private TextView titleAlbum;
private TextView artistAlbum;
private ToggleButton favoriteToggle;
private TextView playRadio;
private TextView playRandom;
private TextView playNext;
private TextView addToQueue;
private TextView Download;
private TextView goToArtist;
@Nullable
@Override
public View onCreateView(LayoutInflater inflater, @Nullable ViewGroup container, @Nullable Bundle savedInstanceState) {
@ -74,28 +62,28 @@ public class AlbumBottomSheetDialog extends BottomSheetDialogFragment implements
private void init(View view) {
activity = (MainActivity) requireActivity();
coverAlbum = view.findViewById(R.id.album_cover_image_view);
ImageView coverAlbum = view.findViewById(R.id.album_cover_image_view);
CustomGlideRequest.Builder
.from(requireContext(), albumBottomSheetViewModel.getAlbum().getPrimary(), CustomGlideRequest.ALBUM_PIC, null)
.build()
.transform(new RoundedCorners(CustomGlideRequest.CORNER_RADIUS))
.into(coverAlbum);
titleAlbum = view.findViewById(R.id.album_title_text_view);
TextView titleAlbum = view.findViewById(R.id.album_title_text_view);
titleAlbum.setText(MusicUtil.getReadableString(albumBottomSheetViewModel.getAlbum().getTitle()));
titleAlbum.setSelected(true);
artistAlbum = view.findViewById(R.id.album_artist_text_view);
TextView artistAlbum = view.findViewById(R.id.album_artist_text_view);
artistAlbum.setText(MusicUtil.getReadableString(albumBottomSheetViewModel.getAlbum().getArtistName()));
favoriteToggle = view.findViewById(R.id.button_favorite);
ToggleButton favoriteToggle = view.findViewById(R.id.button_favorite);
favoriteToggle.setChecked(albumBottomSheetViewModel.getAlbum().isFavorite());
favoriteToggle.setOnClickListener(v -> {
albumBottomSheetViewModel.setFavorite();
dismissBottomSheet();
});
playRadio = view.findViewById(R.id.play_radio_text_view);
TextView playRadio = view.findViewById(R.id.play_radio_text_view);
playRadio.setOnClickListener(v -> {
AlbumRepository albumRepository = new AlbumRepository(App.getInstance());
albumRepository.getInstantMix(album, 20, new MediaCallback() {
@ -125,7 +113,7 @@ public class AlbumBottomSheetDialog extends BottomSheetDialogFragment implements
});
});
playRandom = view.findViewById(R.id.play_random_text_view);
TextView playRandom = view.findViewById(R.id.play_random_text_view);
playRandom.setOnClickListener(v -> {
AlbumRepository albumRepository = new AlbumRepository(App.getInstance());
albumRepository.getAlbumTracks(album.getId()).observe(requireActivity(), songs -> {
@ -141,7 +129,7 @@ public class AlbumBottomSheetDialog extends BottomSheetDialogFragment implements
});
});
playNext = view.findViewById(R.id.play_next_text_view);
TextView playNext = view.findViewById(R.id.play_next_text_view);
playNext.setOnClickListener(v -> {
albumBottomSheetViewModel.getAlbumTracks().observe(requireActivity(), songs -> {
MusicPlayerRemote.playNext(songs);
@ -150,7 +138,7 @@ public class AlbumBottomSheetDialog extends BottomSheetDialogFragment implements
});
});
addToQueue = view.findViewById(R.id.add_to_queue_text_view);
TextView addToQueue = view.findViewById(R.id.add_to_queue_text_view);
addToQueue.setOnClickListener(v -> {
albumBottomSheetViewModel.getAlbumTracks().observe(requireActivity(), songs -> {
MusicPlayerRemote.enqueue(songs);
@ -158,15 +146,15 @@ public class AlbumBottomSheetDialog extends BottomSheetDialogFragment implements
});
});
Download = view.findViewById(R.id.download_text_view);
Download.setOnClickListener(v -> {
TextView download = view.findViewById(R.id.download_text_view);
download.setOnClickListener(v -> {
albumBottomSheetViewModel.getAlbumTracks().observe(requireActivity(), songs -> {
DownloadUtil.getDownloadTracker(requireContext()).toggleDownload(songs);
dismissBottomSheet();
});
});
goToArtist = view.findViewById(R.id.go_to_artist_text_view);
TextView goToArtist = view.findViewById(R.id.go_to_artist_text_view);
goToArtist.setOnClickListener(v -> {
albumBottomSheetViewModel.getArtist().observe(requireActivity(), artist -> {
if (artist != null) {

View file

@ -41,13 +41,6 @@ public class ArtistBottomSheetDialog extends BottomSheetDialogFragment implement
private ArtistBottomSheetViewModel artistBottomSheetViewModel;
private Artist artist;
private ImageView coverArtist;
private TextView nameArtist;
private ToggleButton favoriteToggle;
private TextView playRadio;
private TextView playRandom;
@Nullable
@Override
public View onCreateView(LayoutInflater inflater, @Nullable ViewGroup container, @Nullable Bundle savedInstanceState) {
@ -66,25 +59,25 @@ public class ArtistBottomSheetDialog extends BottomSheetDialogFragment implement
private void init(View view) {
activity = (MainActivity) requireActivity();
coverArtist = view.findViewById(R.id.artist_cover_image_view);
ImageView coverArtist = view.findViewById(R.id.artist_cover_image_view);
CustomGlideRequest.Builder
.from(requireContext(), artistBottomSheetViewModel.getArtist().getPrimary(), CustomGlideRequest.ARTIST_PIC, null)
.build()
.transform(new RoundedCorners(CustomGlideRequest.CORNER_RADIUS))
.into(coverArtist);
nameArtist = view.findViewById(R.id.song_title_text_view);
TextView nameArtist = view.findViewById(R.id.song_title_text_view);
nameArtist.setText(MusicUtil.getReadableString(artistBottomSheetViewModel.getArtist().getName()));
nameArtist.setSelected(true);
favoriteToggle = view.findViewById(R.id.button_favorite);
ToggleButton favoriteToggle = view.findViewById(R.id.button_favorite);
favoriteToggle.setChecked(artistBottomSheetViewModel.getArtist().isFavorite());
favoriteToggle.setOnClickListener(v -> {
artistBottomSheetViewModel.setFavorite();
dismissBottomSheet();
});
playRadio = view.findViewById(R.id.play_radio_text_view);
TextView playRadio = view.findViewById(R.id.play_radio_text_view);
playRadio.setOnClickListener(v -> {
ArtistRepository artistRepository = new ArtistRepository(App.getInstance());
artistRepository.getInstantMix(artist, 20, new MediaCallback() {
@ -114,7 +107,7 @@ public class ArtistBottomSheetDialog extends BottomSheetDialogFragment implement
});
});
playRandom = view.findViewById(R.id.play_random_text_view);
TextView playRandom = view.findViewById(R.id.play_random_text_view);
playRandom.setOnClickListener(v -> {
ArtistRepository artistRepository = new ArtistRepository(App.getInstance());
artistRepository.getArtistRandomSong(requireActivity(), artist, 20).observe(requireActivity(), songs -> {

View file

@ -43,19 +43,7 @@ public class SongBottomSheetDialog extends BottomSheetDialogFragment implements
private SongBottomSheetViewModel songBottomSheetViewModel;
private Song song;
private ImageView coverSong;
private TextView titleSong;
private TextView artistSong;
private ToggleButton favoriteToggle;
private TextView playRadio;
private TextView playNext;
private TextView addToQueue;
private TextView rate;
private TextView download;
private TextView addToPlaylist;
private TextView goToAlbum;
private TextView goToArtist;
@Nullable
@Override
@ -68,28 +56,28 @@ public class SongBottomSheetDialog extends BottomSheetDialogFragment implements
songBottomSheetViewModel.setSong(song);
init(view);
initDownloadedUI();
initDownloadedUI(view.findViewById(R.id.download_text_view));
return view;
}
private void init(View view) {
coverSong = view.findViewById(R.id.song_cover_image_view);
ImageView coverSong = view.findViewById(R.id.song_cover_image_view);
CustomGlideRequest.Builder
.from(requireContext(), songBottomSheetViewModel.getSong().getPrimary(), CustomGlideRequest.SONG_PIC, null)
.build()
.transform(new RoundedCorners(CustomGlideRequest.CORNER_RADIUS))
.into(coverSong);
titleSong = view.findViewById(R.id.song_title_text_view);
TextView titleSong = view.findViewById(R.id.song_title_text_view);
titleSong.setText(MusicUtil.getReadableString(songBottomSheetViewModel.getSong().getTitle()));
titleSong.setSelected(true);
artistSong = view.findViewById(R.id.song_artist_text_view);
TextView artistSong = view.findViewById(R.id.song_artist_text_view);
artistSong.setText(MusicUtil.getReadableString(songBottomSheetViewModel.getSong().getArtistName()));
favoriteToggle = view.findViewById(R.id.button_favorite);
ToggleButton favoriteToggle = view.findViewById(R.id.button_favorite);
favoriteToggle.setChecked(songBottomSheetViewModel.getSong().isFavorite());
favoriteToggle.setOnClickListener(v -> {
songBottomSheetViewModel.setFavorite();
@ -107,7 +95,7 @@ public class SongBottomSheetDialog extends BottomSheetDialogFragment implements
return true;
});
playRadio = view.findViewById(R.id.play_radio_text_view);
TextView playRadio = view.findViewById(R.id.play_radio_text_view);
playRadio.setOnClickListener(v -> {
List<Song> opener = new ArrayList<>();
opener.add(song);
@ -135,21 +123,21 @@ public class SongBottomSheetDialog extends BottomSheetDialogFragment implements
dismissBottomSheet();
});
playNext = view.findViewById(R.id.play_next_text_view);
TextView playNext = view.findViewById(R.id.play_next_text_view);
playNext.setOnClickListener(v -> {
MusicPlayerRemote.playNext(song);
((MainActivity) requireActivity()).isBottomSheetInPeek(true);
dismissBottomSheet();
});
addToQueue = view.findViewById(R.id.add_to_queue_text_view);
TextView addToQueue = view.findViewById(R.id.add_to_queue_text_view);
addToQueue.setOnClickListener(v -> {
MusicPlayerRemote.enqueue(song);
((MainActivity) requireActivity()).isBottomSheetInPeek(true);
dismissBottomSheet();
});
rate = view.findViewById(R.id.rate_text_view);
TextView rate = view.findViewById(R.id.rate_text_view);
rate.setOnClickListener(v -> {
Bundle bundle = new Bundle();
bundle.putParcelable("song_object", song);
@ -167,7 +155,7 @@ public class SongBottomSheetDialog extends BottomSheetDialogFragment implements
dismissBottomSheet();
});
addToPlaylist = view.findViewById(R.id.add_to_playlist_text_view);
TextView addToPlaylist = view.findViewById(R.id.add_to_playlist_text_view);
addToPlaylist.setOnClickListener(v -> {
Bundle bundle = new Bundle();
bundle.putParcelable("song_object", song);
@ -179,7 +167,7 @@ public class SongBottomSheetDialog extends BottomSheetDialogFragment implements
dismissBottomSheet();
});
goToAlbum = view.findViewById(R.id.go_to_album_text_view);
TextView goToAlbum = view.findViewById(R.id.go_to_album_text_view);
goToAlbum.setOnClickListener(v -> {
songBottomSheetViewModel.getAlbum().observe(requireActivity(), album -> {
if (album != null) {
@ -193,7 +181,7 @@ public class SongBottomSheetDialog extends BottomSheetDialogFragment implements
});
});
goToArtist = view.findViewById(R.id.go_to_artist_text_view);
TextView goToArtist = view.findViewById(R.id.go_to_artist_text_view);
goToArtist.setOnClickListener(v -> {
songBottomSheetViewModel.getArtist().observe(requireActivity(), artist -> {
if (artist != null) {
@ -217,7 +205,7 @@ public class SongBottomSheetDialog extends BottomSheetDialogFragment implements
dismiss();
}
private void initDownloadedUI() {
private void initDownloadedUI(TextView download) {
if (DownloadUtil.getDownloadTracker(requireContext()).isDownloaded(song)) {
download.setText("Remove");
} else {