Code refactor in QueueRepository

This commit is contained in:
CappielloAntonio 2021-08-24 13:10:20 +02:00
parent 62c076718a
commit 68930a19a4

View file

@ -1,17 +1,14 @@
package com.cappielloantonio.play.repository; package com.cappielloantonio.play.repository;
import android.app.Application; import android.app.Application;
import android.util.Log;
import androidx.lifecycle.LiveData; import androidx.lifecycle.LiveData;
import com.cappielloantonio.play.App;
import com.cappielloantonio.play.database.AppDatabase; import com.cappielloantonio.play.database.AppDatabase;
import com.cappielloantonio.play.database.dao.QueueDao; import com.cappielloantonio.play.database.dao.QueueDao;
import com.cappielloantonio.play.model.Queue; import com.cappielloantonio.play.model.Queue;
import com.cappielloantonio.play.model.Song; import com.cappielloantonio.play.model.Song;
import com.cappielloantonio.play.util.MappingUtil; import com.cappielloantonio.play.util.MappingUtil;
import com.cappielloantonio.play.util.PreferenceUtil;
import com.cappielloantonio.play.util.QueueUtil; import com.cappielloantonio.play.util.QueueUtil;
import java.time.Instant; import java.time.Instant;
@ -21,7 +18,7 @@ import java.util.List;
public class QueueRepository { public class QueueRepository {
private static final String TAG = "QueueRepository"; private static final String TAG = "QueueRepository";
private QueueDao queueDao; private final QueueDao queueDao;
public QueueRepository(Application application) { public QueueRepository(Application application) {
AppDatabase database = AppDatabase.getInstance(application); AppDatabase database = AppDatabase.getInstance(application);
@ -99,7 +96,7 @@ public class QueueRepository {
} }
private static class GetSongsThreadSafe implements Runnable { private static class GetSongsThreadSafe implements Runnable {
private QueueDao queueDao; private final QueueDao queueDao;
private List<Song> songs; private List<Song> songs;
public GetSongsThreadSafe(QueueDao queueDao) { public GetSongsThreadSafe(QueueDao queueDao) {
@ -117,8 +114,8 @@ public class QueueRepository {
} }
private static class InsertAllThreadSafe implements Runnable { private static class InsertAllThreadSafe implements Runnable {
private QueueDao queueDao; private final QueueDao queueDao;
private List<Song> songs; private final List<Song> songs;
public InsertAllThreadSafe(QueueDao queueDao, List<Song> songs) { public InsertAllThreadSafe(QueueDao queueDao, List<Song> songs) {
this.queueDao = queueDao; this.queueDao = queueDao;
@ -132,8 +129,8 @@ public class QueueRepository {
} }
private static class DeleteByPositionThreadSafe implements Runnable { private static class DeleteByPositionThreadSafe implements Runnable {
private QueueDao queueDao; private final QueueDao queueDao;
private int position; private final int position;
public DeleteByPositionThreadSafe(QueueDao queueDao, int position) { public DeleteByPositionThreadSafe(QueueDao queueDao, int position) {
this.queueDao = queueDao; this.queueDao = queueDao;
@ -147,7 +144,7 @@ public class QueueRepository {
} }
private static class DeleteAllThreadSafe implements Runnable { private static class DeleteAllThreadSafe implements Runnable {
private QueueDao queueDao; private final QueueDao queueDao;
public DeleteAllThreadSafe(QueueDao queueDao) { public DeleteAllThreadSafe(QueueDao queueDao) {
this.queueDao = queueDao; this.queueDao = queueDao;
@ -160,7 +157,7 @@ public class QueueRepository {
} }
private static class CountThreadSafe implements Runnable { private static class CountThreadSafe implements Runnable {
private QueueDao queueDao; private final QueueDao queueDao;
private int count = 0; private int count = 0;
public CountThreadSafe(QueueDao queueDao) { public CountThreadSafe(QueueDao queueDao) {
@ -178,8 +175,8 @@ public class QueueRepository {
} }
private static class SetTimestampThreadSafe implements Runnable { private static class SetTimestampThreadSafe implements Runnable {
private QueueDao queueDao; private final QueueDao queueDao;
private String songId; private final String songId;
public SetTimestampThreadSafe(QueueDao queueDao, String songId) { public SetTimestampThreadSafe(QueueDao queueDao, String songId) {
this.queueDao = queueDao; this.queueDao = queueDao;