From 3a1ced65d5e3726ee5d09d1a742061e68829a392 Mon Sep 17 00:00:00 2001
From: antonio <antoniocappiello.play@gmail.com>
Date: Sun, 13 Aug 2023 23:17:05 +0200
Subject: [PATCH] feat: added options in settings to define codec and bitrate
 for downloaded tracks

---
 app/src/main/res/values-de/strings.xml      |  1 +
 app/src/main/res/values/arrays.xml          | 57 +++++++++++++++++++++
 app/src/main/res/values/strings.xml         | 10 ++++
 app/src/main/res/xml/global_preferences.xml | 36 +++++++++++++
 4 files changed, 104 insertions(+)

diff --git a/app/src/main/res/values-de/strings.xml b/app/src/main/res/values-de/strings.xml
index bf835cd1..767cd362 100644
--- a/app/src/main/res/values-de/strings.xml
+++ b/app/src/main/res/values-de/strings.xml
@@ -229,6 +229,7 @@
     <string name="settings_title_syncing">Sychronisierung</string>
     <string name="settings_title_transcoding">Transkodierung</string>
     <string name="settings_title_ui">Benutzeroberfläche</string>
+    <string name="settings_transcoded_download">Transcoded download</string>
     <string name="settings_version_title">Version</string>
     <string name="settings_wifi_only_title">Warnung bei Streamen ohne Wi-Fi</string>
     <string name="settings_wifi_only_summary">Um Erlaubnis fragen bevor über das mobile Netzwerk gestreamed wird.</string>
diff --git a/app/src/main/res/values/arrays.xml b/app/src/main/res/values/arrays.xml
index f6cebaa1..0fa847e3 100644
--- a/app/src/main/res/values/arrays.xml
+++ b/app/src/main/res/values/arrays.xml
@@ -90,6 +90,35 @@
         <item>320</item>
     </string-array>
 
+    <string-array name="max_bitrate_download_list_titles">
+        <item>Original</item>
+        <item>32 kbps</item>
+        <item>48 kbps</item>
+        <item>64 kbps</item>
+        <item>80 kbps</item>
+        <item>96 kbps</item>
+        <item>112 kbps</item>
+        <item>128 kbps</item>
+        <item>160 kbps</item>
+        <item>192 kbps</item>
+        <item>256 kbps</item>
+        <item>320 kbps</item>
+    </string-array>
+    <string-array name="max_bitrate_download_list_values">
+        <item>0</item>
+        <item>32</item>
+        <item>48</item>
+        <item>64</item>
+        <item>80</item>
+        <item>96</item>
+        <item>112</item>
+        <item>128</item>
+        <item>160</item>
+        <item>192</item>
+        <item>256</item>
+        <item>320</item>
+    </string-array>
+
     <string-array name="audio_transcode_format_wifi_list_titles">
         <item>Direct play</item>
         <item>Opus</item>
@@ -120,6 +149,21 @@
         <item>flac</item>
     </string-array>
 
+    <string-array name="audio_transcode_format_download_list_titles">
+        <item>Direct download</item>
+        <item>Opus</item>
+        <item>AAC</item>
+        <item>Mp3</item>
+        <item>Flac</item>
+    </string-array>
+    <string-array name="audio_transcode_format_download_list_values">
+        <item>raw</item>
+        <item>opus</item>
+        <item>aac</item>
+        <item>mp3</item>
+        <item>flac</item>
+    </string-array>
+
     <string-array name="queue_syncing_countdown_titles">
         <item>Ten seconds</item>
         <item>Five seconds</item>
@@ -152,4 +196,17 @@
         <item>track</item>
         <item>album</item>
     </string-array>
+
+    <string-array name="transcoded_download_option_list_titles">
+        <item>Do not transcode</item>
+        <item>Server settings</item>
+        <item>Wi-Fi Transcode format</item>
+        <item>Mobile Transcode format</item>
+    </string-array>
+    <string-array name="transcoded_download_option_list_values">
+        <item>0</item>
+        <item>1</item>
+        <item>2</item>
+        <item>3</item>
+    </string-array>
 </resources>
\ No newline at end of file
diff --git a/app/src/main/res/values/strings.xml b/app/src/main/res/values/strings.xml
index 4f6e0ea5..e9528c17 100644
--- a/app/src/main/res/values/strings.xml
+++ b/app/src/main/res/values/strings.xml
@@ -183,9 +183,15 @@
     <string name="server_unreachable_dialog_summary">The requested server is unavailable. If you choose to continue this dialog will not appear for the next hour.</string>
     <string name="settings_about_summary">Tempo is an open source and lightweight music client for Subsonic, designed and built natively for Android.</string>
     <string name="settings_about_title">About</string>
+    <string name="settings_audio_transcode_download_priority_summary">If enabled, Tempo will not force download the track with the transcode settings below.</string>
+    <string name="settings_audio_transcode_download_priority_title">Prioritize server settings used for streaming in downloads</string>
+    <string name="settings_audio_transcode_download_summary">If enabled, Tempo will download transcoded tracks.</string>
+    <string name="settings_audio_transcode_download_title">Download transcoded tracks</string>
+    <string name="settings_audio_transcode_download_format">Transcode format</string>
     <string name="settings_audio_transcode_priority_summary">If enabled, Tempo will not force stream the track with the transcode settings below.</string>
     <string name="settings_audio_transcode_priority_title">Prioritize server transcode settings</string>
     <string name="settings_audio_transcode_priority_toast">Priority on transcoding of track given to server</string>
+    <string name="settings_audio_transcode_format_download">Transcode format for downloads</string>
     <string name="settings_audio_transcode_format_mobile">Transcode format in mobile</string>
     <string name="settings_audio_transcode_format_wifi">Transcode format in Wi-Fi</string>
     <string name="settings_covers_cache">Size of artwork cache</string>
@@ -201,6 +207,7 @@
     <string name="settings_github_title">Github</string>
     <string name="settings_image_size">Set image resolution</string>
     <string name="settings_logout_title">Log out</string>
+    <string name="settings_max_bitrate_download">Bitrate for downloads</string>
     <string name="settings_max_bitrate_wifi">Bitrate in Wi-Fi</string>
     <string name="settings_max_bitrate_mobile">Bitrate in mobile</string>
     <string name="settings_media_cache">Size of media file cache</string>
@@ -222,6 +229,7 @@
     <string name="settings_summary_replay_gain">Replay gain is a feature that allows you to adjust the volume level of audio tracks for a consistent listening experience. This setting is only effective if the track contains the necessary metadata.</string>
     <string name="settings_summary_syncing">Returns the state of the play queue for this user. This includes the tracks in the play queue, the currently playing track, and the position within this track. The server must support this feature.</string>
     <string name="settings_summary_transcoding">Priority given to the transcoding mode. If set to \"Direct play\" the bitrate of the file will not be changed.</string>
+    <string name="settings_summary_transcoding_download">Download transcoded media. If enabled, the download endpoint will not be used, but the following settings. \n\n If \"Transcode format\" is set to \"Direct play\" the bitrate of the file will not be changed.</string>
     <string name="settings_sync_starred_tracks_for_offline_use_summary">If enabled, starred tracks will be downloaded for offline use.</string>
     <string name="settings_sync_starred_tracks_for_offline_use_title">Sync starred tracks for offline use</string>
     <string name="settings_theme">Theme</string>
@@ -230,7 +238,9 @@
     <string name="settings_title_replay_gain">Replay Gain</string>
     <string name="settings_title_syncing">Syncing</string>
     <string name="settings_title_transcoding">Transcoding</string>
+    <string name="settings_title_transcoding_download">Transcoding Download</string>
     <string name="settings_title_ui">UI</string>
+    <string name="settings_transcoded_download">Transcoded download</string>
     <string name="settings_version_summary" translatable="false">3.1.0</string>
     <string name="settings_version_title">Version</string>
     <string name="settings_wifi_only_title">Stream via Wi-Fi only alert</string>
diff --git a/app/src/main/res/xml/global_preferences.xml b/app/src/main/res/xml/global_preferences.xml
index 665a942d..4dde2d4e 100644
--- a/app/src/main/res/xml/global_preferences.xml
+++ b/app/src/main/res/xml/global_preferences.xml
@@ -154,6 +154,42 @@
             app:useSimpleSummaryProvider="true" />
     </PreferenceCategory>
 
+    <PreferenceCategory app:title="@string/settings_title_transcoding_download">
+        <Preference
+            app:selectable="false"
+            app:summary="@string/settings_summary_transcoding_download" />
+
+        <SwitchPreference
+            android:title="@string/settings_audio_transcode_download_title"
+            android:defaultValue="false"
+            android:summary="@string/settings_audio_transcode_download_summary"
+            android:key="audio_transcode_download" />
+
+        <SwitchPreference
+            android:title="@string/settings_audio_transcode_download_priority_title"
+            android:defaultValue="false"
+            android:summary="@string/settings_audio_transcode_download_priority_summary"
+            android:key="audio_transcode_download_priority" />
+
+        <ListPreference
+            app:defaultValue="raw"
+            app:dialogTitle="@string/settings_audio_transcode_format_download"
+            app:entries="@array/audio_transcode_format_download_list_titles"
+            app:entryValues="@array/audio_transcode_format_download_list_values"
+            app:key="audio_transcode_format_download"
+            app:title="@string/settings_audio_transcode_format_download"
+            app:useSimpleSummaryProvider="true" />
+
+        <ListPreference
+            app:defaultValue="0"
+            app:dialogTitle="@string/settings_max_bitrate_download"
+            app:entries="@array/max_bitrate_download_list_titles"
+            app:entryValues="@array/max_bitrate_download_list_values"
+            app:key="max_bitrate_download"
+            app:title="@string/settings_max_bitrate_download"
+            app:useSimpleSummaryProvider="true" />
+    </PreferenceCategory>
+
     <PreferenceCategory app:title="@string/settings_title_replay_gain">
         <Preference
             app:selectable="false"