From 377606970667b068309c22ede3bdba1d49c7dae9 Mon Sep 17 00:00:00 2001 From: CappielloAntonio Date: Mon, 19 Apr 2021 17:52:29 +0200 Subject: [PATCH] Moved init methods in onViewCreated in home/library --- .../play/ui/fragment/HomeFragment.java | 12 +++++++++--- .../play/ui/fragment/LibraryFragment.java | 14 +++++++++++--- app/src/main/res/layout/fragment_library.xml | 1 + 3 files changed, 21 insertions(+), 6 deletions(-) diff --git a/app/src/main/java/com/cappielloantonio/play/ui/fragment/HomeFragment.java b/app/src/main/java/com/cappielloantonio/play/ui/fragment/HomeFragment.java index 39d651d3..49651963 100644 --- a/app/src/main/java/com/cappielloantonio/play/ui/fragment/HomeFragment.java +++ b/app/src/main/java/com/cappielloantonio/play/ui/fragment/HomeFragment.java @@ -51,14 +51,20 @@ public class HomeFragment extends Fragment { homeViewModel = new ViewModelProvider(requireActivity()).get(HomeViewModel.class); init(); + + return view; + } + + @Override + public void onViewCreated(@NonNull View view, @Nullable Bundle savedInstanceState) { + super.onViewCreated(view, savedInstanceState); + initDiscoverSongSlideView(); initMostPlayedSongView(); initRecentPlayedSongView(); initFavoritesSongView(); initYearSongView(); initRecentAddedSongView(); - - return view; } @Override @@ -116,7 +122,7 @@ public class HomeFragment extends Fragment { mostPlayedMusicAdapter = new RecentMusicAdapter(activity, requireContext(), getChildFragmentManager()); bind.mostPlayedTracksRecyclerView.setAdapter(mostPlayedMusicAdapter); homeViewModel.getMostPlayedSongList().observe(requireActivity(), songs -> { - if(songs.isEmpty()) reorder(); + if(songs.size() < 10) reorder(); bind.homeMostPlayedTracksSector.setVisibility(!songs.isEmpty() ? View.VISIBLE : View.GONE); mostPlayedMusicAdapter.setItems(songs); diff --git a/app/src/main/java/com/cappielloantonio/play/ui/fragment/LibraryFragment.java b/app/src/main/java/com/cappielloantonio/play/ui/fragment/LibraryFragment.java index 79b16e39..8ae01849 100644 --- a/app/src/main/java/com/cappielloantonio/play/ui/fragment/LibraryFragment.java +++ b/app/src/main/java/com/cappielloantonio/play/ui/fragment/LibraryFragment.java @@ -47,13 +47,19 @@ public class LibraryFragment extends Fragment { libraryViewModel = new ViewModelProvider(requireActivity()).get(LibraryViewModel.class); init(); + + return view; + } + + @Override + public void onViewCreated(@NonNull View view, @Nullable Bundle savedInstanceState) { + super.onViewCreated(view, savedInstanceState); + initAlbumView(); initArtistView(); initGenreView(); initPlaylistView(); initCatalogueSyncCheck(); - - return view; } @Override @@ -104,7 +110,9 @@ public class LibraryFragment extends Fragment { activity.navController.navigate(R.id.action_libraryFragment_to_songListPageFragment, bundle); }); bind.genreRecyclerView.setAdapter(genreAdapter); - libraryViewModel.getGenreSample().observe(requireActivity(), genres -> genreAdapter.setItems(genres)); + libraryViewModel.getGenreSample().observe(requireActivity(), genres -> { + genreAdapter.setItems(genres); + }); } private void initPlaylistView() { diff --git a/app/src/main/res/layout/fragment_library.xml b/app/src/main/res/layout/fragment_library.xml index d06fcbe1..7e57ba7c 100644 --- a/app/src/main/res/layout/fragment_library.xml +++ b/app/src/main/res/layout/fragment_library.xml @@ -139,6 +139,7 @@