Remove unused permission and its request

This commit is contained in:
CappielloAntonio 2021-07-21 17:02:50 +02:00
parent 862fbd512a
commit 18227f0aa3
2 changed files with 4 additions and 38 deletions

View file

@ -5,7 +5,6 @@
<uses-permission android:name="android.permission.INTERNET"/> <uses-permission android:name="android.permission.INTERNET"/>
<uses-permission android:name="android.permission.FOREGROUND_SERVICE"/> <uses-permission android:name="android.permission.FOREGROUND_SERVICE"/>
<uses-permission android:name="android.permission.WRITE_EXTERNAL_STORAGE" tools:ignore="ScopedStorage" />
<application <application
android:name="App" android:name="App"

View file

@ -1,6 +1,5 @@
package com.cappielloantonio.play.ui.activity.base; package com.cappielloantonio.play.ui.activity.base;
import android.Manifest;
import android.content.BroadcastReceiver; import android.content.BroadcastReceiver;
import android.content.ComponentName; import android.content.ComponentName;
import android.content.Context; import android.content.Context;
@ -12,18 +11,17 @@ import android.os.IBinder;
import android.os.PowerManager; import android.os.PowerManager;
import android.provider.Settings; import android.provider.Settings;
import android.util.Log; import android.util.Log;
import android.widget.Toast;
import androidx.annotation.NonNull; import androidx.annotation.NonNull;
import androidx.appcompat.app.AlertDialog; import androidx.appcompat.app.AlertDialog;
import androidx.appcompat.app.AppCompatActivity; import androidx.appcompat.app.AppCompatActivity;
import com.cappielloantonio.play.R; import com.cappielloantonio.play.R;
import com.cappielloantonio.play.service.MusicPlayerRemote;
import com.cappielloantonio.play.interfaces.MusicServiceEventListener; import com.cappielloantonio.play.interfaces.MusicServiceEventListener;
import com.cappielloantonio.play.service.DownloadTracker; import com.cappielloantonio.play.service.DownloadTracker;
import com.cappielloantonio.play.service.MusicService;
import com.cappielloantonio.play.service.DownloaderService; import com.cappielloantonio.play.service.DownloaderService;
import com.cappielloantonio.play.service.MusicPlayerRemote;
import com.cappielloantonio.play.service.MusicService;
import com.cappielloantonio.play.util.DownloadUtil; import com.cappielloantonio.play.util.DownloadUtil;
import com.google.android.exoplayer2.offline.DownloadService; import com.google.android.exoplayer2.offline.DownloadService;
@ -31,12 +29,8 @@ import java.lang.ref.WeakReference;
import java.util.ArrayList; import java.util.ArrayList;
import java.util.List; import java.util.List;
import pub.devrel.easypermissions.AppSettingsDialog; public class BaseActivity extends AppCompatActivity implements MusicServiceEventListener, DownloadTracker.Listener {
import pub.devrel.easypermissions.EasyPermissions;
public class BaseActivity extends AppCompatActivity implements EasyPermissions.PermissionCallbacks, MusicServiceEventListener, DownloadTracker.Listener {
private static final String TAG = "BaseActivity"; private static final String TAG = "BaseActivity";
public static final int REQUEST_PERM_ACCESS = 1;
private final List<MusicServiceEventListener> mMusicServiceEventListeners = new ArrayList<>(); private final List<MusicServiceEventListener> mMusicServiceEventListeners = new ArrayList<>();
@ -87,7 +81,7 @@ public class BaseActivity extends AppCompatActivity implements EasyPermissions.P
@Override @Override
protected void onResume() { protected void onResume() {
super.onResume(); super.onResume();
checkPermissions(); // checkPermissions();
checkBatteryOptimization(); checkBatteryOptimization();
} }
@ -135,33 +129,6 @@ public class BaseActivity extends AppCompatActivity implements EasyPermissions.P
startActivity(intent); startActivity(intent);
} }
private void checkPermissions() {
String[] permissions = {Manifest.permission.WRITE_EXTERNAL_STORAGE};
if (!EasyPermissions.hasPermissions(this, permissions)) {
EasyPermissions.requestPermissions(this, getString(R.string.storage_permission_rationale), REQUEST_PERM_ACCESS, permissions);
}
}
@Override
public void onPermissionsGranted(int requestCode, @NonNull List<String> perms) {
}
@Override
public void onPermissionsDenied(int requestCode, @NonNull List<String> perms) {
if (EasyPermissions.somePermissionPermanentlyDenied(this, perms)) {
new AppSettingsDialog.Builder(this).build().show();
}
}
@Override
public void onRequestPermissionsResult(int requestCode, @NonNull String[] permissions, @NonNull int[] grantResults) {
super.onRequestPermissionsResult(requestCode, permissions, grantResults);
EasyPermissions.onRequestPermissionsResult(requestCode, permissions, grantResults, this);
}
public void addMusicServiceEventListener(final MusicServiceEventListener listener) { public void addMusicServiceEventListener(final MusicServiceEventListener listener) {
if (listener != null) { if (listener != null) {
mMusicServiceEventListeners.add(listener); mMusicServiceEventListeners.add(listener);