From 06066f1f66aabf38e5d727bee5cf5a07d502d683 Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Jaime=20Garc=C3=ADa?=
 <55400857+jaime-grj@users.noreply.github.com>
Date: Mon, 8 Sep 2025 20:08:05 +0200
Subject: [PATCH] refactor: Remove redundant null checks after loading
 equalizer band levels

---
 .../tempo/ui/fragment/EqualizerFragment.kt                | 8 +++-----
 .../com/cappielloantonio/tempo/service/MediaService.kt    | 6 ++----
 .../com/cappielloantonio/tempo/service/MediaService.kt    | 6 ++----
 .../com/cappielloantonio/tempo/service/MediaService.kt    | 6 ++----
 4 files changed, 9 insertions(+), 17 deletions(-)

diff --git a/app/src/main/java/com/cappielloantonio/tempo/ui/fragment/EqualizerFragment.kt b/app/src/main/java/com/cappielloantonio/tempo/ui/fragment/EqualizerFragment.kt
index 16c58457..13d93c09 100644
--- a/app/src/main/java/com/cappielloantonio/tempo/ui/fragment/EqualizerFragment.kt
+++ b/app/src/main/java/com/cappielloantonio/tempo/ui/fragment/EqualizerFragment.kt
@@ -215,11 +215,9 @@ class EqualizerFragment : Fragment() {
         val bandLevelRange = manager.getBandLevelRange() ?: shortArrayOf(-1500, 1500)
         val minLevel = bandLevelRange[0].toInt()
         val savedLevels = Preferences.getEqualizerBandLevels(bands)
-        if (savedLevels != null) {
-            for (i in 0 until bands) {
-                manager.setBandLevel(i.toShort(), savedLevels[i])
-                bandSeekBars.getOrNull(i)?.progress = savedLevels[i] - minLevel
-            }
+        for (i in 0 until bands) {
+            manager.setBandLevel(i.toShort(), savedLevels[i])
+            bandSeekBars.getOrNull(i)?.progress = savedLevels[i] - minLevel
         }
     }
 }
\ No newline at end of file
diff --git a/app/src/notquitemy/java/com/cappielloantonio/tempo/service/MediaService.kt b/app/src/notquitemy/java/com/cappielloantonio/tempo/service/MediaService.kt
index cbced233..f0a5d43f 100644
--- a/app/src/notquitemy/java/com/cappielloantonio/tempo/service/MediaService.kt
+++ b/app/src/notquitemy/java/com/cappielloantonio/tempo/service/MediaService.kt
@@ -229,10 +229,8 @@ class MediaService : MediaLibraryService() {
 
             val bands = equalizerManager.getNumberOfBands()
             val savedLevels = Preferences.getEqualizerBandLevels(bands)
-            if (savedLevels != null) {
-                for (i in 0 until bands) {
-                    equalizerManager.setBandLevel(i.toShort(), savedLevels[i])
-                }
+            for (i in 0 until bands) {
+                equalizerManager.setBandLevel(i.toShort(), savedLevels[i])
             }
         }
     }
diff --git a/app/src/play/java/com/cappielloantonio/tempo/service/MediaService.kt b/app/src/play/java/com/cappielloantonio/tempo/service/MediaService.kt
index a4854281..a4658aa1 100644
--- a/app/src/play/java/com/cappielloantonio/tempo/service/MediaService.kt
+++ b/app/src/play/java/com/cappielloantonio/tempo/service/MediaService.kt
@@ -120,10 +120,8 @@ class MediaService : MediaLibraryService(), SessionAvailabilityListener {
 
             val bands = equalizerManager.getNumberOfBands()
             val savedLevels = Preferences.getEqualizerBandLevels(bands)
-            if (savedLevels != null) {
-                for (i in 0 until bands) {
-                    equalizerManager.setBandLevel(i.toShort(), savedLevels[i])
-                }
+            for (i in 0 until bands) {
+                equalizerManager.setBandLevel(i.toShort(), savedLevels[i])
             }
         }
     }
diff --git a/app/src/tempo/java/com/cappielloantonio/tempo/service/MediaService.kt b/app/src/tempo/java/com/cappielloantonio/tempo/service/MediaService.kt
index 345b44b2..8cafde24 100644
--- a/app/src/tempo/java/com/cappielloantonio/tempo/service/MediaService.kt
+++ b/app/src/tempo/java/com/cappielloantonio/tempo/service/MediaService.kt
@@ -106,10 +106,8 @@ class MediaService : MediaLibraryService(), SessionAvailabilityListener {
 
             val bands = equalizerManager.getNumberOfBands()
             val savedLevels = Preferences.getEqualizerBandLevels(bands)
-            if (savedLevels != null) {
-                for (i in 0 until bands) {
-                    equalizerManager.setBandLevel(i.toShort(), savedLevels[i])
-                }
+            for (i in 0 until bands) {
+                equalizerManager.setBandLevel(i.toShort(), savedLevels[i])
             }
         }
     }