fix: Replace hardcoded strings in SettingsFragment

This commit is contained in:
Jaime García 2025-10-08 22:17:30 +02:00
parent e87b658447
commit 04f34e03d1
No known key found for this signature in database
GPG key ID: 6785B7B157936146
3 changed files with 19 additions and 7 deletions

View file

@ -92,7 +92,7 @@ public class SettingsFragment extends PreferenceFragmentCompat {
Preferences.setDownloadDirectoryUri(uri.toString()); Preferences.setDownloadDirectoryUri(uri.toString());
ExternalAudioReader.refreshCache(); ExternalAudioReader.refreshCache();
Toast.makeText(requireContext(), "Download folder set.", Toast.LENGTH_SHORT).show(); Toast.makeText(requireContext(), R.string.settings_download_folder_set, Toast.LENGTH_SHORT).show();
checkDownloadDirectory(); checkDownloadDirectory();
} }
} }
@ -238,15 +238,15 @@ public class SettingsFragment extends PreferenceFragmentCompat {
if (storage != null) storage.setVisible(false); if (storage != null) storage.setVisible(false);
directory.setVisible(true); directory.setVisible(true);
directory.setIcon(R.drawable.ic_close); directory.setIcon(R.drawable.ic_close);
directory.setTitle("Clear download folder"); directory.setTitle(R.string.settings_clear_download_folder);
directory.setSummary(current); directory.setSummary(current);
} else { } else {
if (storage != null) storage.setVisible(true); if (storage != null) storage.setVisible(true);
if (Preferences.getDownloadStoragePreference() == 2) { if (Preferences.getDownloadStoragePreference() == 2) {
directory.setVisible(true); directory.setVisible(true);
directory.setIcon(R.drawable.ic_folder); directory.setIcon(R.drawable.ic_folder);
directory.setTitle("Set download folder"); directory.setTitle(R.string.settings_set_download_folder);
directory.setSummary("Choose a folder for downloaded music files"); directory.setSummary(R.string.settings_choose_download_folder);
} else { } else {
directory.setVisible(false); directory.setVisible(false);
} }
@ -325,7 +325,7 @@ public class SettingsFragment extends PreferenceFragmentCompat {
@Override @Override
public void onSuccess(boolean isScanning, long count) { public void onSuccess(boolean isScanning, long count) {
findPreference("scan_library").setSummary("Scanning: counting " + count + " tracks"); findPreference("scan_library").setSummary(getString(R.string.settings_scan_result, count));
if (isScanning) getScanStatus(); if (isScanning) getScanStatus();
} }
}); });
@ -430,7 +430,7 @@ public class SettingsFragment extends PreferenceFragmentCompat {
Preferences.setDownloadDirectoryUri(null); Preferences.setDownloadDirectoryUri(null);
Preferences.setDownloadStoragePreference(0); Preferences.setDownloadStoragePreference(0);
ExternalAudioReader.refreshCache(); ExternalAudioReader.refreshCache();
Toast.makeText(requireContext(), "Download folder cleared.", Toast.LENGTH_SHORT).show(); Toast.makeText(requireContext(), R.string.settings_download_folder_cleared, Toast.LENGTH_SHORT).show();
checkStorage(); checkStorage();
checkDownloadDirectory(); checkDownloadDirectory();
} else { } else {
@ -492,7 +492,7 @@ public class SettingsFragment extends PreferenceFragmentCompat {
@Override @Override
public void onSuccess(boolean isScanning, long count) { public void onSuccess(boolean isScanning, long count) {
findPreference("scan_library").setSummary("Scanning: counting " + count + " tracks"); findPreference("scan_library").setSummary(getString(R.string.settings_scan_result, count));
if (isScanning) getScanStatus(); if (isScanning) getScanStatus();
} }
}); });

View file

@ -170,6 +170,7 @@
<string name="menu_filter_download">Descargado</string> <string name="menu_filter_download">Descargado</string>
<string name="menu_group_by_album">Álbum</string> <string name="menu_group_by_album">Álbum</string>
<string name="menu_group_by_artist">Artista</string> <string name="menu_group_by_artist">Artista</string>
<string name="settings_scan_result">Escaneo: hay %1$d pistas</string>
<string name="settings_image_size">Resolución de la imagen</string> <string name="settings_image_size">Resolución de la imagen</string>
<string name="settings_language">Idioma</string> <string name="settings_language">Idioma</string>
<string name="settings_system_language">Idioma del sistema</string> <string name="settings_system_language">Idioma del sistema</string>
@ -257,6 +258,7 @@
<string name="search_hint">Buscar pista, artistas o álbumes</string> <string name="search_hint">Buscar pista, artistas o álbumes</string>
<string name="search_info_minimum_characters">Introduzca al menos tres caracteres</string> <string name="search_info_minimum_characters">Introduzca al menos tres caracteres</string>
<string name="search_title_album">Álbumes</string> <string name="search_title_album">Álbumes</string>
<string name="settings_set_download_folder">Establecer la carpeta de descargas</string>
<string name="settings_system_equalizer_summary">Ajustes de audio</string> <string name="settings_system_equalizer_summary">Ajustes de audio</string>
<string name="settings_system_equalizer_title">Ecualizador del sistema</string> <string name="settings_system_equalizer_title">Ecualizador del sistema</string>
<string name="search_title_artist">Artistas</string> <string name="search_title_artist">Artistas</string>
@ -295,6 +297,8 @@
<string name="settings_audio_transcode_priority_toast">Prioridad a la hora de transcodificar una pista</string> <string name="settings_audio_transcode_priority_toast">Prioridad a la hora de transcodificar una pista</string>
<string name="settings_buffering_strategy">Estrategia de buffer</string> <string name="settings_buffering_strategy">Estrategia de buffer</string>
<string name="settings_buffering_strategy_summary">Para que los cambios surtan efecto, debes reinciar la app.</string> <string name="settings_buffering_strategy_summary">Para que los cambios surtan efecto, debes reinciar la app.</string>
<string name="settings_choose_download_folder">Elige una carpeta para descargar los archivos de música</string>
<string name="settings_clear_download_folder">Limpiar la carpeta de descargas</string>
<string name="settings_continuous_play_summary">Permite que la música siga reproduciéndose una vez que la lista de reproducción ha terminado, reproduciendo pistas similares</string> <string name="settings_continuous_play_summary">Permite que la música siga reproduciéndose una vez que la lista de reproducción ha terminado, reproduciendo pistas similares</string>
<string name="settings_continuous_play_title">Reproducción continua</string> <string name="settings_continuous_play_title">Reproducción continua</string>
<string name="settings_covers_cache">Tamaño de la caché de portadas de álbumes</string> <string name="settings_covers_cache">Tamaño de la caché de portadas de álbumes</string>
@ -441,4 +445,6 @@
<string name="equalizer_not_supported">No disponible en este dispositivo</string> <string name="equalizer_not_supported">No disponible en este dispositivo</string>
<string name="settings_app_equalizer">Ecualizador</string> <string name="settings_app_equalizer">Ecualizador</string>
<string name="settings_app_equalizer_summary">Abrir el ecualizador integrado</string> <string name="settings_app_equalizer_summary">Abrir el ecualizador integrado</string>
<string name="settings_download_folder_cleared">Se ha limpiado la carpeta de descargas.</string>
<string name="settings_download_folder_set">Se ha establecido la carpeta de descargas</string>
</resources> </resources>

View file

@ -311,6 +311,8 @@
<string name="settings_audio_transcode_priority_toast">Priority on transcoding of track given to server</string> <string name="settings_audio_transcode_priority_toast">Priority on transcoding of track given to server</string>
<string name="settings_buffering_strategy">Buffering strategy</string> <string name="settings_buffering_strategy">Buffering strategy</string>
<string name="settings_buffering_strategy_summary">For the change to take effect you must manually restart the app.</string> <string name="settings_buffering_strategy_summary">For the change to take effect you must manually restart the app.</string>
<string name="settings_choose_download_folder">Choose a folder for downloaded music files</string>
<string name="settings_clear_download_folder">Clear download folder</string>
<string name="settings_continuous_play_summary">Allows music to keep playing after a playlist has ended, playing similar songs</string> <string name="settings_continuous_play_summary">Allows music to keep playing after a playlist has ended, playing similar songs</string>
<string name="settings_continuous_play_title">Continuous play</string> <string name="settings_continuous_play_title">Continuous play</string>
<string name="settings_covers_cache">Size of artwork cache</string> <string name="settings_covers_cache">Size of artwork cache</string>
@ -319,6 +321,9 @@
<string name="settings_delete_download_storage_summary">Proceeding will result in the irreversible deletion of all saved items.</string> <string name="settings_delete_download_storage_summary">Proceeding will result in the irreversible deletion of all saved items.</string>
<string name="settings_delete_download_storage_title">Delete saved items</string> <string name="settings_delete_download_storage_title">Delete saved items</string>
<string name="settings_download_storage_title">Download storage</string> <string name="settings_download_storage_title">Download storage</string>
<string name="settings_download_folder_cleared">Download folder cleared.</string>
<string name="settings_download_folder_set">Download folder set</string>
<string name="settings_set_download_folder">Set download folder</string>
<string name="settings_system_equalizer_summary">Adjust audio settings</string> <string name="settings_system_equalizer_summary">Adjust audio settings</string>
<string name="settings_system_equalizer_title">System equalizer</string> <string name="settings_system_equalizer_title">System equalizer</string>
<string name="settings_github_link">https://github.com/eddyizm/tempo</string> <string name="settings_github_link">https://github.com/eddyizm/tempo</string>
@ -327,6 +332,7 @@
<string name="settings_support_discussion_link">https://github.com/eddyizm/tempo/discussions</string> <string name="settings_support_discussion_link">https://github.com/eddyizm/tempo/discussions</string>
<string name="settings_support_summary">Join community discussions and support</string> <string name="settings_support_summary">Join community discussions and support</string>
<string name="settings_support_title">User support</string> <string name="settings_support_title">User support</string>
<string name="settings_scan_result">Scanning: counting %1$d tracks</string>
<string name="settings_image_size">Set image resolution</string> <string name="settings_image_size">Set image resolution</string>
<string name="settings_language">Language</string> <string name="settings_language">Language</string>
<string name="settings_logout_title">Log out</string> <string name="settings_logout_title">Log out</string>