add navidrome version check for smart playlists

src/renderer/api/controller.ts

@@ -173,7 +173,7 @@ const endpoints: ApiController = {
         getPlaylistList: ndController.getPlaylistList,
         getPlaylistSongList: ndController.getPlaylistSongList,
         getRandomSongList: ssController.getRandomSongList,
-        getServerInfo: ssController.getServerInfo,
+        getServerInfo: ndController.getServerInfo,
         getSongDetail: ndController.getSongDetail,
         getSongList: ndController.getSongList,
         getStructuredLyrics: ssController.getStructuredLyrics,

src/renderer/api/navidrome/navidrome-controller.ts

@@ -1,3 +1,9 @@
+import { ndApiClient } from '/@/renderer/api/navidrome/navidrome-api';
+import { ndNormalize } from '/@/renderer/api/navidrome/navidrome-normalize';
+import { NavidromeExtensions, ndType } from '/@/renderer/api/navidrome/navidrome-types';
+import { ssApiClient } from '/@/renderer/api/subsonic/subsonic-api';
+import semverCoerce from 'semver/functions/coerce';
+import semverGte from 'semver/functions/gte';
 import {
     AlbumArtistDetailArgs,
     AlbumArtistDetailResponse,
@@ -39,11 +45,10 @@ import {
     RemoveFromPlaylistResponse,
     RemoveFromPlaylistArgs,
     genreListSortMap,
+    ServerInfo,
+    ServerInfoArgs,
 } from '../types';
-import { ndApiClient } from '/@/renderer/api/navidrome/navidrome-api';
-import { ndNormalize } from '/@/renderer/api/navidrome/navidrome-normalize';
-import { ndType } from '/@/renderer/api/navidrome/navidrome-types';
-import { ssApiClient } from '/@/renderer/api/subsonic/subsonic-api';
+import { hasFeature } from '/@/renderer/api/utils';
 
 const authenticate = async (
     url: string,
@@ -355,6 +360,16 @@ const deletePlaylist = async (args: DeletePlaylistArgs): Promise<DeletePlaylistR
 
 const getPlaylistList = async (args: PlaylistListArgs): Promise<PlaylistListResponse> => {
     const { query, apiClientProps } = args;
+    const customQuery = query._custom?.navidrome;
+
+    // Smart playlists only became available in 0.48.0. Do not filter for previous versions
+    if (
+        customQuery &&
+        customQuery.smart !== undefined &&
+        !hasFeature(apiClientProps.server, NavidromeExtensions.SMART_PLAYLISTS)
+    ) {
+        customQuery.smart = undefined;
+    }
 
     const res = await ndApiClient(apiClientProps).getPlaylistList({
         query: {
@@ -363,7 +378,7 @@ const getPlaylistList = async (args: PlaylistListArgs): Promise<PlaylistListResp
             _sort: query.sortBy ? playlistListSortMap.navidrome[query.sortBy] : undefined,
             _start: query.startIndex,
             q: query.searchTerm,
-            ...query._custom?.navidrome,
+            ...customQuery,
         },
     });
 
@@ -465,6 +480,61 @@ const removeFromPlaylist = async (
     return null;
 };
 
+const VERSION_INFO: Array<[string, Record<string, number[]>]> = [
+    ['0.48.0', { [NavidromeExtensions.SMART_PLAYLISTS]: [1] }],
+];
+
+const getFeatures = (version: string): Record<string, number[]> => {
+    const cleanVersion = semverCoerce(version);
+    const features: Record<string, number[]> = {};
+    let matched = cleanVersion === null;
+
+    for (const [version, supportedFeatures] of VERSION_INFO) {
+        if (!matched) {
+            matched = semverGte(cleanVersion!, version);
+        }
+
+        if (matched) {
+            for (const [feature, feat] of Object.entries(supportedFeatures)) {
+                if (feature in features) {
+                    features[feature].push(...feat);
+                } else {
+                    features[feature] = feat;
+                }
+            }
+        }
+    }
+
+    return features;
+};
+
+const getServerInfo = async (args: ServerInfoArgs): Promise<ServerInfo> => {
+    const { apiClientProps } = args;
+
+    // Navidrome will always populate serverVersion
+    const ping = await ssApiClient(apiClientProps).ping();
+
+    if (ping.status !== 200) {
+        throw new Error('Failed to ping server');
+    }
+
+    const features: Record<string, number[]> = getFeatures(ping.body.serverVersion!);
+
+    if (ping.body.openSubsonic) {
+        const res = await ssApiClient(apiClientProps).getServerInfo();
+
+        if (res.status !== 200) {
+            throw new Error('Failed to get server extensions');
+        }
+
+        for (const extension of res.body.openSubsonicExtensions) {
+            features[extension.name] = extension.versions;
+        }
+    }
+
+    return { features, id: apiClientProps.server?.id, version: ping.body.serverVersion! };
+};
+
 export const ndController = {
     addToPlaylist,
     authenticate,
@@ -478,6 +548,7 @@ export const ndController = {
     getPlaylistDetail,
     getPlaylistList,
     getPlaylistSongList,
+    getServerInfo,
     getSongDetail,
     getSongList,
     getUserList,

src/renderer/api/navidrome/navidrome-types.ts

@@ -342,6 +342,10 @@ const removeFromPlaylistParameters = z.object({
     id: z.array(z.string()),
 });
 
+export enum NavidromeExtensions {
+    SMART_PLAYLISTS = 'smartPlaylists',
+}
+
 export const ndType = {
     _enum: {
         albumArtistList: ndAlbumArtistListSort,

src/renderer/api/types.ts

@@ -57,13 +57,16 @@ export type User = {
 
 export type ServerListItem = {
     credential: string;
+    features?: Record<string, number[]>;
     id: string;
     name: string;
     ndCredential?: string;
+    savePassword?: boolean;
     type: ServerType;
     url: string;
     userId: string | null;
     username: string;
+    version?: string;
 };
 
 export enum ServerType {

src/renderer/api/utils.ts

@@ -38,3 +38,20 @@ export const authenticationFailure = (currentServer: ServerListItem | null) => {
         useAuthStore.getState().actions.setCurrentServer(null);
     }
 };
+
+export const hasFeature = (
+    server: ServerListItem | null,
+    feature: string,
+    version = 1,
+): boolean => {
+    if (!server || !server.features) {
+        return false;
+    }
+
+    const versions = server.features[feature];
+    if (!versions || versions.length === 0) {
+        return false;
+    }
+
+    return versions.includes(version);
+};

src/renderer/features/lyrics/queries/lyric-query.ts

@@ -15,6 +15,7 @@ import { queryKeys } from '/@/renderer/api/query-keys';
 import { ServerType } from '/@/renderer/types';
 import { api } from '/@/renderer/api';
 import isElectron from 'is-electron';
+import { hasFeature } from '/@/renderer/api/utils';
 
 const lyricsIpc = isElectron() ? window.electron.lyrics : null;
 
@@ -112,7 +113,7 @@ export const useSongLyricsBySong = (
                         source: server?.name ?? 'music server',
                     };
                 }
-            } else if (server.features && SubsonicExtensions.SONG_LYRICS in server.features) {
+            } else if (hasFeature(server, SubsonicExtensions.SONG_LYRICS)) {
                 const subsonicLyrics = await api.controller
                     .getStructuredLyrics({
                         apiClientProps: { server, signal },

src/renderer/features/playlists/components/create-playlist-form.tsx

@@ -11,6 +11,8 @@ import { useCreatePlaylist } from '/@/renderer/features/playlists/mutations/crea
 import { convertQueryGroupToNDQuery } from '/@/renderer/features/playlists/utils';
 import { useCurrentServer } from '/@/renderer/store';
 import { useTranslation } from 'react-i18next';
+import { hasFeature } from '/@/renderer/api/utils';
+import { NavidromeExtensions } from '/@/renderer/api/navidrome/navidrome-types';
 
 interface CreatePlaylistFormProps {
     onCancel: () => void;
@@ -120,12 +122,13 @@ export const CreatePlaylistForm = ({ onCancel }: CreatePlaylistFormProps) => {
                             })}
                         />
                     )}
-                    {server?.type === ServerType.NAVIDROME && (
-                        <Switch
-                            label="Is smart playlist?"
-                            onChange={(e) => setIsSmartPlaylist(e.currentTarget.checked)}
-                        />
-                    )}
+                    {server?.type === ServerType.NAVIDROME &&
+                        hasFeature(server, NavidromeExtensions.SMART_PLAYLISTS) && (
+                            <Switch
+                                label="Is smart playlist?"
+                                onChange={(e) => setIsSmartPlaylist(e.currentTarget.checked)}
+                            />
+                        )}
                 </Group>
                 {server?.type === ServerType.NAVIDROME && isSmartPlaylist && (
                     <Stack pt="1rem">

src/renderer/hooks/use-server-version.ts

@@ -3,6 +3,7 @@ import { useAuthStoreActions, useCurrentServer } from '/@/renderer/store';
 import { useQuery } from '@tanstack/react-query';
 import { queryKeys } from '/@/renderer/api/query-keys';
 import { controller } from '/@/renderer/api/controller';
+import isEqual from 'lodash/isEqual';
 
 export const useServerVersion = () => {
     const { updateServer } = useAuthStoreActions();
@@ -24,7 +25,7 @@ export const useServerVersion = () => {
     useEffect(() => {
         if (server && server.id === serverInfo.data?.id) {
             const { version, features } = serverInfo.data;
-            if (version !== server.version) {
+            if (version !== server.version || !isEqual(features, server.features)) {
                 updateServer(server.id, {
                     features,
                     version,

src/renderer/types.ts

@@ -54,25 +54,7 @@ export enum Platform {
     WINDOWS = 'windows',
 }
 
-export enum ServerType {
-    JELLYFIN = 'jellyfin',
-    NAVIDROME = 'navidrome',
-    SUBSONIC = 'subsonic',
-}
-
-export type ServerListItem = {
-    credential: string;
-    features?: Record<string, number[]>;
-    id: string;
-    name: string;
-    ndCredential?: string;
-    savePassword?: boolean;
-    type: ServerType;
-    url: string;
-    userId: string | null;
-    username: string;
-    version?: string;
-};
+export { ServerType, ServerListItem } from '/@/renderer/api/types';
 
 export enum PlayerStatus {
     PAUSED = 'paused',