[bugfix]: Handle top-level songs for Jellyfin (#553)

* [bugfix]: Handle top-level songs for Jellyfin

If a song is at the top level of a music folder, Jellyfin will not
group that into an album (See https://jellyfin.org/docs/general/server/media/music/).

This PR introduces a few changes:
- Gives tracks with no album ID a special route (`/dummy/${id}`)
- Gives a new route for dummy albums, warning about the error. This is designed to look _like_ the album detail page

* `are are` > `are`

* revert name changes
This commit is contained in:
Kendall Garner 2024-04-30 03:18:43 +00:00 committed by GitHub
parent 620cca9ce3
commit 9cd8807a75
No known key found for this signature in database
GPG key ID: B5690EEEBB952194
8 changed files with 292 additions and 2 deletions

View file

@ -185,6 +185,15 @@ export const contract = c.router({
400: jfType._response.error,
},
},
getSongData: {
method: 'GET',
path: 'users/:userId/items/:id',
query: jfType._parameters.songDetail,
responses: {
200: jfType._response.song,
400: jfType._response.error,
},
},
getSongDetail: {
method: 'GET',
path: 'users/:userId/items/:id',

View file

@ -134,7 +134,7 @@ const normalizeSong = (
imageUrl: null,
name: entry.Name,
})),
albumId: item.AlbumId,
albumId: item.AlbumId || `dummy/${item.Id}`,
artistName: item?.ArtistItems?.[0]?.Name,
artists: item?.ArtistItems?.map((entry) => ({
id: entry.Id,

View file

@ -387,11 +387,13 @@ const genericItem = z.object({
Name: z.string(),
});
const songDetailParameters = baseParameters;
const song = z.object({
Album: z.string(),
AlbumArtist: z.string(),
AlbumArtists: z.array(genericItem),
AlbumId: z.string(),
AlbumId: z.string().optional(),
AlbumPrimaryImageTag: z.string(),
ArtistItems: z.array(genericItem),
Artists: z.array(z.string()),
@ -709,6 +711,7 @@ export const jfType = {
search: searchParameters,
similarArtistList: similarArtistListParameters,
similarSongs: similarSongsParameters,
songDetail: songDetailParameters,
songList: songListParameters,
updatePlaylist: updatePlaylistParameters,
},