From 9b7950202211dc5189b326768815c92c1dec8c98 Mon Sep 17 00:00:00 2001
From: Kendall Garner <17521368+kgarner7@users.noreply.github.com>
Date: Sat, 7 Jun 2025 20:36:41 -0700
Subject: [PATCH] config option for listenbrainz/lastfm links

---
 src/i18n/locales/en.json                      |  4 ++
 .../components/album-detail-content.tsx       | 42 ++++++++--------
 .../album-artist-detail-content.tsx           | 42 ++++++++--------
 .../components/general/control-settings.tsx   | 49 ++++++++++++++++++-
 src/renderer/store/settings.store.ts          |  4 ++
 5 files changed, 99 insertions(+), 42 deletions(-)

diff --git a/src/i18n/locales/en.json b/src/i18n/locales/en.json
index 6154d651..1c44c054 100644
--- a/src/i18n/locales/en.json
+++ b/src/i18n/locales/en.json
@@ -587,6 +587,8 @@
         "imageAspectRatio_description": "if enabled, cover art will be shown using their native aspect ratio. for art that is not 1:1, the remaining space will be empty",
         "language": "language",
         "language_description": "sets the language for the application ($t(common.restartRequired))",
+        "lastfm": "show last.fm links",
+        "lastfm_description": "show links to last.fm on artist/album pages",
         "lastfmApiKey": "{{lastfm}} API key",
         "lastfmApiKey_description": "the API key for {{lastfm}}. required for cover art",
         "lyricFetch": "fetch lyrics from the internet",
@@ -605,6 +607,8 @@
         "mpvExecutablePath_description": "sets the path to the mpv executable. if left empty, the default path will be used",
         "mpvExtraParameters": "mpv parameters",
         "mpvExtraParameters_help": "one per line",
+        "musicbrainz": "show musicbrainz links",
+        "musicbrainz_description": "show links to musicbrainz on artist/album pages, where mbid exists",
         "passwordStore": "passwords/secret store",
         "passwordStore_description": "what password/secret store to use. change this if you are having issues storing passwords.",
         "playbackStyle": "playback style",
diff --git a/src/renderer/features/albums/components/album-detail-content.tsx b/src/renderer/features/albums/components/album-detail-content.tsx
index c5b4e23f..33d21980 100644
--- a/src/renderer/features/albums/components/album-detail-content.tsx
+++ b/src/renderer/features/albums/components/album-detail-content.tsx
@@ -90,7 +90,7 @@ export const AlbumDetailContent = ({ background, tableRef }: AlbumDetailContentP
     const status = useCurrentStatus();
     const isFocused = useAppFocus();
     const currentSong = useCurrentSong();
-    const { externalLinks } = useGeneralSettings();
+    const { lastFM, musicBrainz } = useGeneralSettings();
     const genreRoute = useGenreRoute();
 
     const columnDefs = useMemo(
@@ -407,27 +407,29 @@ export const AlbumDetailContent = ({ background, tableRef }: AlbumDetailContentP
                         </Group>
                     </Box>
                 )}
-                {externalLinks ? (
+                {lastFM || musicBrainz ? (
                     <Box component="section">
                         <Group spacing="sm">
-                            <Button
-                                compact
-                                component="a"
-                                href={`https://www.last.fm/music/${encodeURIComponent(
-                                    detailQuery?.data?.albumArtist || '',
-                                )}/${encodeURIComponent(detailQuery.data?.name || '')}`}
-                                radius="md"
-                                rel="noopener noreferrer"
-                                size="md"
-                                target="_blank"
-                                tooltip={{
-                                    label: t('action.openIn.lastfm'),
-                                }}
-                                variant="subtle"
-                            >
-                                <FaLastfmSquare size={25} />
-                            </Button>
-                            {mbzId ? (
+                            {lastFM && (
+                                <Button
+                                    compact
+                                    component="a"
+                                    href={`https://www.last.fm/music/${encodeURIComponent(
+                                        detailQuery?.data?.albumArtist || '',
+                                    )}/${encodeURIComponent(detailQuery.data?.name || '')}`}
+                                    radius="md"
+                                    rel="noopener noreferrer"
+                                    size="md"
+                                    target="_blank"
+                                    tooltip={{
+                                        label: t('action.openIn.lastfm'),
+                                    }}
+                                    variant="subtle"
+                                >
+                                    <FaLastfmSquare size={25} />
+                                </Button>
+                            )}
+                            {musicBrainz && mbzId ? (
                                 <Button
                                     compact
                                     component="a"
diff --git a/src/renderer/features/artists/components/album-artist-detail-content.tsx b/src/renderer/features/artists/components/album-artist-detail-content.tsx
index 1215a64d..d4beadf6 100644
--- a/src/renderer/features/artists/components/album-artist-detail-content.tsx
+++ b/src/renderer/features/artists/components/album-artist-detail-content.tsx
@@ -66,7 +66,7 @@ interface AlbumArtistDetailContentProps {
 
 export const AlbumArtistDetailContent = ({ background }: AlbumArtistDetailContentProps) => {
     const { t } = useTranslation();
-    const { artistItems, externalLinks } = useGeneralSettings();
+    const { artistItems, lastFM, musicBrainz } = useGeneralSettings();
     const { albumArtistId, artistId } = useParams() as {
         albumArtistId?: string;
         artistId?: string;
@@ -451,27 +451,29 @@ export const AlbumArtistDetailContent = ({ background }: AlbumArtistDetailConten
                         </Group>
                     </Box>
                 ) : null}
-                {externalLinks ? (
+                {lastFM || musicBrainz ? (
                     <Box component="section">
                         <Group spacing="sm">
-                            <Button
-                                compact
-                                component="a"
-                                href={`https://www.last.fm/music/${encodeURIComponent(
-                                    detailQuery?.data?.name || '',
-                                )}`}
-                                radius="md"
-                                rel="noopener noreferrer"
-                                size="md"
-                                target="_blank"
-                                tooltip={{
-                                    label: t('action.openIn.lastfm'),
-                                }}
-                                variant="subtle"
-                            >
-                                <FaLastfmSquare size={25} />
-                            </Button>
-                            {mbzId ? (
+                            {lastFM && (
+                                <Button
+                                    compact
+                                    component="a"
+                                    href={`https://www.last.fm/music/${encodeURIComponent(
+                                        detailQuery?.data?.name || '',
+                                    )}`}
+                                    radius="md"
+                                    rel="noopener noreferrer"
+                                    size="md"
+                                    target="_blank"
+                                    tooltip={{
+                                        label: t('action.openIn.lastfm'),
+                                    }}
+                                    variant="subtle"
+                                >
+                                    <FaLastfmSquare size={25} />
+                                </Button>
+                            )}
+                            {musicBrainz && mbzId ? (
                                 <Button
                                     compact
                                     component="a"
diff --git a/src/renderer/features/settings/components/general/control-settings.tsx b/src/renderer/features/settings/components/general/control-settings.tsx
index 730a4a7d..686c7aec 100644
--- a/src/renderer/features/settings/components/general/control-settings.tsx
+++ b/src/renderer/features/settings/components/general/control-settings.tsx
@@ -4,7 +4,10 @@ import isElectron from 'is-electron';
 import { useTranslation } from 'react-i18next';
 
 import { NumberInput, Select, Slider, Switch, Tooltip } from '/@/renderer/components';
-import { SettingsSection } from '/@/renderer/features/settings/components/settings-section';
+import {
+    SettingOption,
+    SettingsSection,
+} from '/@/renderer/features/settings/components/settings-section';
 import {
     GenreTarget,
     SideQueueType,
@@ -37,7 +40,7 @@ export const ControlSettings = () => {
     const settings = useGeneralSettings();
     const { setSettings } = useSettingsStoreActions();
 
-    const controlOptions = [
+    const controlOptions: SettingOption[] = [
         {
             control: (
                 <NumberInput
@@ -396,6 +399,48 @@ export const ControlSettings = () => {
             }),
             title: t('setting.externalLinks', { postProcess: 'sentenceCase' }),
         },
+        {
+            control: (
+                <Switch
+                    defaultChecked={settings.lastFM}
+                    onChange={(e) => {
+                        setSettings({
+                            general: {
+                                ...settings,
+                                lastFM: e.currentTarget.checked,
+                            },
+                        });
+                    }}
+                />
+            ),
+            description: t('setting.lastfm', {
+                context: 'description',
+                postProcess: 'sentenceCase',
+            }),
+            isHidden: !settings.externalLinks,
+            title: t('setting.lastfm', { postProcess: 'sentenceCase' }),
+        },
+        {
+            control: (
+                <Switch
+                    defaultChecked={settings.musicBrainz}
+                    onChange={(e) => {
+                        setSettings({
+                            general: {
+                                ...settings,
+                                musicBrainz: e.currentTarget.checked,
+                            },
+                        });
+                    }}
+                />
+            ),
+            description: t('setting.musicbrainz', {
+                context: 'description',
+                postProcess: 'sentenceCase',
+            }),
+            isHidden: !settings.externalLinks,
+            title: t('setting.musicbrainz', { postProcess: 'sentenceCase' }),
+        },
         {
             control: (
                 <Select
diff --git a/src/renderer/store/settings.store.ts b/src/renderer/store/settings.store.ts
index 9336fe93..f1208b70 100644
--- a/src/renderer/store/settings.store.ts
+++ b/src/renderer/store/settings.store.ts
@@ -227,7 +227,9 @@ export interface SettingsState {
         homeFeature: boolean;
         homeItems: SortableItem<HomeItem>[];
         language: string;
+        lastFM: boolean;
         lastfmApiKey: string;
+        musicBrainz: boolean;
         nativeAspectRatio: boolean;
         passwordStore?: string;
         playButtonBehavior: Play;
@@ -376,7 +378,9 @@ const initialState: SettingsState = {
         homeFeature: true,
         homeItems,
         language: 'en',
+        lastFM: true,
         lastfmApiKey: '',
+        musicBrainz: true,
         nativeAspectRatio: false,
         passwordStore: undefined,
         playButtonBehavior: Play.NOW,