Refactor all mutation hooks

This commit is contained in:
jeffvli 2023-04-27 21:44:25 -07:00
parent bf3024939a
commit 68a1cb9aaa
9 changed files with 166 additions and 214 deletions

View file

@ -1,27 +1,35 @@
import { useMutation, useQueryClient } from '@tanstack/react-query';
import { useMutation } from '@tanstack/react-query';
import { HTTPError } from 'ky';
import { api } from '/@/renderer/api';
import { JFAlbumArtistDetail, JFAlbumDetail } from '/@/renderer/api/jellyfin.types';
import { NDAlbumArtistDetail, NDAlbumDetail } from '/@/renderer/api/navidrome.types';
import { queryKeys } from '/@/renderer/api/query-keys';
import { SSAlbumArtistDetail, SSAlbumDetail } from '/@/renderer/api/subsonic.types';
import { FavoriteArgs, LibraryItem, RawFavoriteResponse, ServerType } from '/@/renderer/api/types';
import { MutationOptions } from '/@/renderer/lib/react-query';
import {
useCurrentServer,
useSetAlbumListItemDataById,
useSetQueueFavorite,
} from '/@/renderer/store';
AlbumArtistDetailResponse,
AlbumDetailResponse,
FavoriteArgs,
FavoriteResponse,
LibraryItem,
} from '/@/renderer/api/types';
import { MutationHookArgs, queryClient } from '/@/renderer/lib/react-query';
import { getServerById, useSetAlbumListItemDataById, useSetQueueFavorite } from '/@/renderer/store';
export const useCreateFavorite = (options?: MutationOptions) => {
const queryClient = useQueryClient();
const server = useCurrentServer();
export const useCreateFavorite = (args?: MutationHookArgs) => {
const { options } = args || {};
const setAlbumListData = useSetAlbumListItemDataById();
const setQueueFavorite = useSetQueueFavorite();
return useMutation<RawFavoriteResponse, HTTPError, Omit<FavoriteArgs, 'server'>, null>({
mutationFn: (args) => api.controller.createFavorite({ ...args, server }),
return useMutation<
FavoriteResponse,
HTTPError,
Omit<FavoriteArgs, 'server' | 'apiClientProps'>,
null
>({
mutationFn: (args) => {
const server = getServerById(args.serverId);
if (!server) throw new Error('Server not found');
return api.controller.createFavorite({ ...args, apiClientProps: { server } });
},
onSuccess: (_data, variables) => {
const { serverId } = variables;
for (const id of variables.query.id) {
// Set the userFavorite property to true for the album in the album list data store
if (variables.query.type === LibraryItem.ALBUM) {
@ -35,71 +43,33 @@ export const useCreateFavorite = (options?: MutationOptions) => {
// We only need to set if we're already on the album detail page
if (variables.query.type === LibraryItem.ALBUM && variables.query.id.length === 1) {
const queryKey = queryKeys.albums.detail(server?.id || '', { id: variables.query.id[0] });
const previous = queryClient.getQueryData<any>(queryKey);
const queryKey = queryKeys.albums.detail(serverId, { id: variables.query.id[0] });
const previous = queryClient.getQueryData<AlbumDetailResponse>(queryKey);
if (previous) {
switch (server?.type) {
case ServerType.NAVIDROME:
queryClient.setQueryData<NDAlbumDetail>(queryKey, {
...previous,
starred: true,
});
break;
case ServerType.SUBSONIC:
queryClient.setQueryData<SSAlbumDetail>(queryKey, {
...previous,
starred: true,
});
break;
case ServerType.JELLYFIN:
queryClient.setQueryData<JFAlbumDetail>(queryKey, {
...previous,
UserData: {
...previous.UserData,
IsFavorite: true,
},
});
break;
}
queryClient.setQueryData<AlbumDetailResponse>(queryKey, {
...previous,
userFavorite: true,
});
}
}
// We only need to set if we're already on the album detail page
if (variables.query.type === LibraryItem.ALBUM_ARTIST && variables.query.id.length === 1) {
const queryKey = queryKeys.albumArtists.detail(server?.id || '', {
const queryKey = queryKeys.albumArtists.detail(serverId, {
id: variables.query.id[0],
});
const previous = queryClient.getQueryData<any>(queryKey);
const previous = queryClient.getQueryData<AlbumArtistDetailResponse>(queryKey);
if (previous) {
switch (server?.type) {
case ServerType.NAVIDROME:
queryClient.setQueryData<NDAlbumArtistDetail>(queryKey, {
...previous,
starred: true,
});
break;
case ServerType.SUBSONIC:
queryClient.setQueryData<SSAlbumArtistDetail>(queryKey, {
...previous,
starred: true,
});
break;
case ServerType.JELLYFIN:
queryClient.setQueryData<JFAlbumArtistDetail>(queryKey, {
...previous,
UserData: {
...previous.UserData,
IsFavorite: true,
},
});
break;
}
queryClient.setQueryData<AlbumArtistDetailResponse>(queryKey, {
...previous,
userFavorite: true,
});
}
}
},
...options,
});
};

View file

@ -1,27 +1,36 @@
import { useMutation, useQueryClient } from '@tanstack/react-query';
import { useMutation } from '@tanstack/react-query';
import { HTTPError } from 'ky';
import { api } from '/@/renderer/api';
import { JFAlbumArtistDetail, JFAlbumDetail } from '/@/renderer/api/jellyfin.types';
import { NDAlbumArtistDetail, NDAlbumDetail } from '/@/renderer/api/navidrome.types';
import { queryKeys } from '/@/renderer/api/query-keys';
import { SSAlbumArtistDetail, SSAlbumDetail } from '/@/renderer/api/subsonic.types';
import { FavoriteArgs, LibraryItem, RawFavoriteResponse, ServerType } from '/@/renderer/api/types';
import { MutationOptions } from '/@/renderer/lib/react-query';
import {
useCurrentServer,
useSetAlbumListItemDataById,
useSetQueueFavorite,
} from '/@/renderer/store';
AlbumArtistDetailResponse,
AlbumDetailResponse,
FavoriteArgs,
FavoriteResponse,
LibraryItem,
} from '/@/renderer/api/types';
import { MutationHookArgs, queryClient } from '/@/renderer/lib/react-query';
import { getServerById, useSetAlbumListItemDataById, useSetQueueFavorite } from '/@/renderer/store';
export const useDeleteFavorite = (options?: MutationOptions) => {
const queryClient = useQueryClient();
const server = useCurrentServer();
export const useDeleteFavorite = (args: MutationHookArgs) => {
const { options } = args || {};
// const queryClient = useQueryClient();
const setAlbumListData = useSetAlbumListItemDataById();
const setQueueFavorite = useSetQueueFavorite();
return useMutation<RawFavoriteResponse, HTTPError, Omit<FavoriteArgs, 'server'>, null>({
mutationFn: (args) => api.controller.deleteFavorite({ ...args, server }),
return useMutation<
FavoriteResponse,
HTTPError,
Omit<FavoriteArgs, 'server' | 'apiClientProps'>,
null
>({
mutationFn: (args) => {
const server = getServerById(args.serverId);
if (!server) throw new Error('Server not found');
return api.controller.deleteFavorite({ ...args, apiClientProps: { server } });
},
onSuccess: (_data, variables) => {
const { serverId } = variables;
for (const id of variables.query.id) {
// Set the userFavorite property to false for the album in the album list data store
if (variables.query.type === LibraryItem.ALBUM) {
@ -35,67 +44,29 @@ export const useDeleteFavorite = (options?: MutationOptions) => {
// We only need to set if we're already on the album detail page
if (variables.query.type === LibraryItem.ALBUM && variables.query.id.length === 1) {
const queryKey = queryKeys.albums.detail(server?.id || '', { id: variables.query.id[0] });
const previous = queryClient.getQueryData<any>(queryKey);
const queryKey = queryKeys.albums.detail(serverId, { id: variables.query.id[0] });
const previous = queryClient.getQueryData<AlbumDetailResponse>(queryKey);
if (previous) {
switch (server?.type) {
case ServerType.NAVIDROME:
queryClient.setQueryData<NDAlbumDetail>(queryKey, {
...previous,
starred: false,
});
break;
case ServerType.SUBSONIC:
queryClient.setQueryData<SSAlbumDetail>(queryKey, {
...previous,
starred: false,
});
break;
case ServerType.JELLYFIN:
queryClient.setQueryData<JFAlbumDetail>(queryKey, {
...previous,
UserData: {
...previous.UserData,
IsFavorite: false,
},
});
break;
}
queryClient.setQueryData<AlbumDetailResponse>(queryKey, {
...previous,
userFavorite: false,
});
}
}
// We only need to set if we're already on the album detail page
// We only need to set if we're already on the album artist detail page
if (variables.query.type === LibraryItem.ALBUM_ARTIST && variables.query.id.length === 1) {
const queryKey = queryKeys.albumArtists.detail(server?.id || '', {
const queryKey = queryKeys.albumArtists.detail(serverId, {
id: variables.query.id[0],
});
const previous = queryClient.getQueryData<any>(queryKey);
const previous = queryClient.getQueryData<AlbumArtistDetailResponse>(queryKey);
if (previous) {
switch (server?.type) {
case ServerType.NAVIDROME:
queryClient.setQueryData<NDAlbumArtistDetail>(queryKey, {
...previous,
starred: false,
});
break;
case ServerType.SUBSONIC:
queryClient.setQueryData<SSAlbumArtistDetail>(queryKey, {
...previous,
starred: false,
});
break;
case ServerType.JELLYFIN:
queryClient.setQueryData<JFAlbumArtistDetail>(queryKey, {
...previous,
UserData: {
...previous.UserData,
IsFavorite: false,
},
});
break;
}
queryClient.setQueryData<AlbumArtistDetailResponse>(queryKey, {
...previous,
userFavorite: false,
});
}
}
},

View file

@ -9,33 +9,29 @@ import {
AlbumArtist,
AnyLibraryItems,
LibraryItem,
RatingArgs,
RawRatingResponse,
SetRatingArgs,
RatingResponse,
ServerType,
} from '/@/renderer/api/types';
import { MutationOptions } from '/@/renderer/lib/react-query';
import {
useAuthStore,
useCurrentServer,
useSetAlbumListItemDataById,
useSetQueueRating,
} from '/@/renderer/store';
import { MutationHookArgs } from '/@/renderer/lib/react-query';
import { getServerById, useSetAlbumListItemDataById, useSetQueueRating } from '/@/renderer/store';
export const useUpdateRating = (options?: MutationOptions) => {
export const useSetRating = (args: MutationHookArgs) => {
const { options } = args || {};
const queryClient = useQueryClient();
const currentServer = useCurrentServer();
const setAlbumListData = useSetAlbumListItemDataById();
const setQueueRating = useSetQueueRating();
return useMutation<
RawRatingResponse,
RatingResponse,
HTTPError,
Omit<RatingArgs, 'server'>,
Omit<SetRatingArgs, 'server' | 'apiClientProps'>,
{ previous: { items: AnyLibraryItems } | undefined }
>({
mutationFn: (args) => {
const server = useAuthStore.getState().actions.getServer(args._serverId) || currentServer;
return api.controller.updateRating({ ...args, server });
const server = getServerById(args.serverId);
if (!server) throw new Error('Server not found');
return api.controller.updateRating({ ...args, apiClientProps: { server } });
},
onError: (_error, _variables, context) => {
for (const item of context?.previous?.items || []) {
@ -127,7 +123,6 @@ export const useUpdateRating = (options?: MutationOptions) => {
}
}
},
...options,
});
};