antebudimir/feishin
1
0
Fork 0
mirror of https://github.com/antebudimir/feishin.git synced 2026-01-01 18:33:33 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions 1

[bugfix/feat]: always fetch artist image for Navidrome (#317)

Browse source 
* [bugfix/feat]: always fetch artist image for Navidrome

* Add error fallback to library header image

---------

Co-authored-by: jeffvli <jeffvictorli@gmail.com>
This commit is contained in:
Kendall Garner 2023-10-22 22:46:48 +00:00 • committed by GitHub
parent 74cab01013
commit 452ef783f2
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
2 changed files with 19 additions and 7 deletions
Download patch file Download diff file Expand all files Collapse all files

11
src/renderer/features/shared/components/library-header.tsx
View file

@ -1,5 +1,5 @@
import { Group } from '@mantine/core';
import { forwardRef, ReactNode, Ref } from 'react';
import { forwardRef, ReactNode, Ref, useState } from 'react';
import { Link } from 'react-router-dom';
import styles from './library-header.module.scss';
import { LibraryItem } from '/@/renderer/api/types';
@ -20,6 +20,12 @@ export const LibraryHeader = forwardRef(
{ imageUrl, imagePlaceholderUrl, background, title, item, children }: LibraryHeaderProps,
ref: Ref<HTMLDivElement>,
) => {
const [isImageError, setIsImageError] = useState<boolean | null>(false);
const onImageError = () => {
setIsImageError(true);
};
return (
<div
ref={ref}
@ -31,13 +37,14 @@ export const LibraryHeader = forwardRef(
/>
<div className={styles.backgroundOverlay} />
<div className={styles.imageSection}>
{imageUrl ? (
{imageUrl && !isImageError ? (
<img
alt="cover"
className={styles.image}
placeholder={imagePlaceholderUrl || 'var(--placeholder-bg)'}
src={imageUrl}
style={{ height: '' }}
onError={onImageError}
/>
) : (
<ItemImagePlaceholder itemType={item.type} />