From 2d9176cd210a350c655eb02d9b02f6416123cd2b Mon Sep 17 00:00:00 2001 From: jeffvli Date: Tue, 8 Jul 2025 00:46:50 -0700 Subject: [PATCH] fix click propagation on right controls --- .../player/components/right-controls.tsx | 18 +++++++++++++++--- 1 file changed, 15 insertions(+), 3 deletions(-) diff --git a/src/renderer/features/player/components/right-controls.tsx b/src/renderer/features/player/components/right-controls.tsx index 9b34f820..f79062bd 100644 --- a/src/renderer/features/player/components/right-controls.tsx +++ b/src/renderer/features/player/components/right-controls.tsx @@ -227,6 +227,9 @@ export const RightControls = () => { iconProps={{ size: 'lg', }} + onClick={(e) => { + e.stopPropagation(); + }} size="sm" tooltip={{ label: t('player.playbackSpeed', { postProcess: 'sentenceCase' }), @@ -268,7 +271,10 @@ export const RightControls = () => { fill: currentSong?.userFavorite ? 'primary' : undefined, size: 'lg', }} - onClick={() => handleToggleFavorite(currentSong)} + onClick={(e) => { + e.stopPropagation(); + handleToggleFavorite(currentSong); + }} size="sm" tooltip={{ label: currentSong?.userFavorite @@ -283,7 +289,10 @@ export const RightControls = () => { iconProps={{ size: 'lg', }} - onClick={handleToggleQueue} + onClick={(e) => { + e.stopPropagation(); + handleToggleQueue(); + }} size="sm" tooltip={{ label: t('player.viewQueue', { postProcess: 'titleCase' }), @@ -297,7 +306,10 @@ export const RightControls = () => { color: muted ? 'muted' : undefined, size: 'xl', }} - onClick={handleMute} + onClick={(e) => { + e.stopPropagation(); + handleMute(); + }} onWheel={handleVolumeWheel} size="sm" tooltip={{