From 2cf0027419a4798fd72bf05e3477e6d7770bf30d Mon Sep 17 00:00:00 2001
From: Kendall Garner <17521368+kgarner7@users.noreply.github.com>
Date: Fri, 5 Sep 2025 19:55:58 -0700
Subject: [PATCH] only show translation when api key and provider are picked,
 and fix eslint vscode

---
 .vscode/settings.json                         |  3 +--
 .../features/lyrics/lyrics-actions.tsx        |  4 ++--
 src/renderer/features/lyrics/lyrics.tsx       | 20 ++++++++++++++-----
 .../components/playback/lyric-settings.tsx    |  1 +
 4 files changed, 19 insertions(+), 9 deletions(-)

diff --git a/.vscode/settings.json b/.vscode/settings.json
index f524cf9a..3ba28d28 100644
--- a/.vscode/settings.json
+++ b/.vscode/settings.json
@@ -13,10 +13,9 @@
         ".prettierrc": "jsonc",
         ".eslintignore": "ignore"
     },
-    "eslint.validate": ["typescript"],
+    "eslint.validate": ["typescript", "typescriptreact"],
     "eslint.workingDirectories": [
         { "directory": "./", "changeProcessCWD": true },
-        { "directory": "./server", "changeProcessCWD": true }
     ],
     "typescript.tsserver.experimental.enableProjectDiagnostics": false,
     "editor.codeActionsOnSave": {
diff --git a/src/renderer/features/lyrics/lyrics-actions.tsx b/src/renderer/features/lyrics/lyrics-actions.tsx
index 47b684b2..3fa3fbc0 100644
--- a/src/renderer/features/lyrics/lyrics-actions.tsx
+++ b/src/renderer/features/lyrics/lyrics-actions.tsx
@@ -24,7 +24,7 @@ interface LyricsActionsProps {
     onRemoveLyric: () => void;
     onResetLyric: () => void;
     onSearchOverride: (params: LyricsOverride) => void;
-    onTranslateLyric: () => void;
+    onTranslateLyric?: () => void;
     setIndex: (idx: number) => void;
 }
 
@@ -135,7 +135,7 @@ export const LyricsActions = ({
             </div>
 
             <div style={{ position: 'absolute', right: 0, top: -50 }}>
-                {isDesktop && sources.length ? (
+                {isDesktop && sources.length && onTranslateLyric ? (
                     <Button
                         disabled={isActionsDisabled}
                         onClick={onTranslateLyric}
diff --git a/src/renderer/features/lyrics/lyrics.tsx b/src/renderer/features/lyrics/lyrics.tsx
index a578e776..d3f37975 100644
--- a/src/renderer/features/lyrics/lyrics.tsx
+++ b/src/renderer/features/lyrics/lyrics.tsx
@@ -32,7 +32,8 @@ import { FullLyricsMetadata, LyricSource, LyricsOverride } from '/@/shared/types
 
 export const Lyrics = () => {
     const currentSong = useCurrentSong();
-    const lyricsSettings = useLyricsSettings();
+    const { translationApiKey, translationApiProvider, translationTargetLanguage } =
+        useLyricsSettings();
     const { t } = useTranslation();
     const [index, setIndex] = useState(0);
     const [translatedLyrics, setTranslatedLyrics] = useState<null | string>(null);
@@ -97,8 +98,6 @@ export const Lyrics = () => {
         const originalLyrics = Array.isArray(lyrics.lyrics)
             ? lyrics.lyrics.map(([, line]) => line).join('\n')
             : lyrics.lyrics;
-        const { translationApiKey, translationApiProvider, translationTargetLanguage } =
-            lyricsSettings;
         const TranslatedText: null | string = await translateLyrics(
             originalLyrics,
             translationApiKey,
@@ -107,7 +106,14 @@ export const Lyrics = () => {
         );
         setTranslatedLyrics(TranslatedText);
         setShowTranslation(true);
-    }, [lyrics, lyricsSettings, translatedLyrics, showTranslation]);
+    }, [
+        translatedLyrics,
+        lyrics,
+        translationApiKey,
+        translationApiProvider,
+        translationTargetLanguage,
+        showTranslation,
+    ]);
 
     const { isInitialLoading: isOverrideLoading } = useSongLyricsByRemoteId({
         options: {
@@ -194,7 +200,11 @@ export const Lyrics = () => {
                         onRemoveLyric={handleOnRemoveLyric}
                         onResetLyric={handleOnResetLyric}
                         onSearchOverride={handleOnSearchOverride}
-                        onTranslateLyric={handleOnTranslateLyric}
+                        onTranslateLyric={
+                            translationApiProvider && translationApiKey
+                                ? handleOnTranslateLyric
+                                : undefined
+                        }
                         setIndex={setIndex}
                     />
                 </div>
diff --git a/src/renderer/features/settings/components/playback/lyric-settings.tsx b/src/renderer/features/settings/components/playback/lyric-settings.tsx
index 30fc8d45..8c1886aa 100644
--- a/src/renderer/features/settings/components/playback/lyric-settings.tsx
+++ b/src/renderer/features/settings/components/playback/lyric-settings.tsx
@@ -181,6 +181,7 @@ export const LyricSettings = () => {
         {
             control: (
                 <Select
+                    clearable
                     data={['Microsoft Azure', 'Google Cloud']}
                     onChange={(value) => {
                         setSettings({ lyrics: { ...settings, translationApiProvider: value } });