antebudimir/eslint-plugin-vanilla-extract
1
0
Fork 0
mirror of https://github.com/antebudimir/eslint-plugin-vanilla-extract.git synced 2026-01-01 17:23:31 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions

fix 🐞: fix false positives for non-empty object arguments in empty-style-blocks rule

Browse source
This commit is contained in:
Ante Budimir 2025-11-22 12:13:26 +02:00
parent 1d88c12e3d
commit d5c99de191
8 changed files with 466 additions and 7 deletions
Download patch file Download diff file Expand all files Collapse all files

28
src/css-rules/no-empty-blocks/recipe-processor.ts
View file

@ -1,6 +1,6 @@
import type { Rule } from 'eslint';
import { TSESTree } from '@typescript-eslint/utils';
import { isEmptyObject } from '../shared-utils/empty-object-processor.js';
import { isCallExpressionWithEmptyObject, isEmptyObject } from '../shared-utils/empty-object-processor.js';
import { processEmptyNestedStyles } from './empty-nested-style-processor.js';
import { removeNodeWithComma } from './node-remover.js';
import { areAllChildrenEmpty, getStyleKeyName } from './property-utils.js';
@ -88,8 +88,30 @@ export const processRecipeProperties = (
return;
}
// Check for non-object variant values
if (variantValueProperty.value.type !== 'ObjectExpression') {
const valueType = variantValueProperty.value.type;
// Allow CallExpression (e.g., sprinkles(), style()) as valid variant values unless it has an empty object argument, e.g. sprinkles({})
if (valueType === 'CallExpression') {
const callExpression = variantValueProperty.value as TSESTree.CallExpression;
if (isCallExpressionWithEmptyObject(callExpression)) {
// Treat sprinkles({}) or style({}) as empty
if (!reportedNodes.has(variantValueProperty)) {
reportedNodes.add(variantValueProperty);
ruleContext.report({
node: variantValueProperty as Rule.Node,
messageId: 'emptyVariantValue',
fix(fixer) {
return removeNodeWithComma(ruleContext, variantValueProperty, fixer);
},
});
}
}
// Valid CallExpressions with arguments are fine
return;
}
// Check for non-object variant values (excluding CallExpression)
if (valueType !== 'ObjectExpression') {
if (!reportedNodes.has(variantValueProperty)) {
reportedNodes.add(variantValueProperty);